Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ligature support to terminal take 2 #139537

Closed
wants to merge 1 commit into from
Closed

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 20, 2021

Migrating over from stale #120452

Part of #34103

Todo:

Migrating over from stale #120452

Part of #34103
@Tyriar Tyriar added this to the January 2022 milestone Dec 20, 2021
@Tyriar Tyriar self-assigned this Dec 20, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Dec 20, 2021

Having some problems with permissions in Electron:

image

Edge seems to have removed the font access flag, but xterm.js' demo in Chrome and it works.

@Tyriar
Copy link
Member Author

Tyriar commented Dec 20, 2021

@deepak1556 any idea how to suppress the user activation requirement? We don't need to worry about this permission for the renderer's main web contents.

@Tyriar
Copy link
Member Author

Tyriar commented Dec 20, 2021

Seg fault when ligatures are enabled on macOS:

[main 2021-12-20T20:48:40.322Z] ExtensionHostStarterWorker created
[74401:1220/124844.691936:INFO:CONSOLE(301)] "%c[Extension Host] %cdebugger listening on port 5870 color: blue color:", source: vscode-file://vscode-app/Users/daimms/dev/Microsoft/vscode/out/vs/workbench/services/extensions/electron-browser/localProcessExtensionHost.js (301)
[main 2021-12-20T20:48:45.718Z] Starting extension host with pid 74477 (fork() took 946 ms).
[74401:1220/124846.043727:INFO:CONSOLE(21)] "Overwriting grammar scope name to file mapping for scope source.java.
Old grammar file: file:///Users/daimms/dev/Microsoft/vscode/extensions/java/syntaxes/java.tmLanguage.json.
New grammar file: file:///Users/daimms/.vscode-oss-dev/extensions/redhat.java-0.79.2/syntaxes/java.tmLanguage.json", source: vscode-file://vscode-app/Users/daimms/dev/Microsoft/vscode/out/vs/workbench/services/textMate/common/TMScopeRegistry.js (21)
[74401:1220/124846.062555:INFO:CONSOLE(209)] "%c[Extension Host] %cdebugger inspector at chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=127.0.0.1:5870/b125824e-9f59-4bad-97c8-bea88fe12996 color: blue color:", source: vscode-file://vscode-app/Users/daimms/dev/Microsoft/vscode/out/vs/workbench/services/extensions/electron-browser/localProcessExtensionHost.js (209)
Debugger listening on ws://127.0.0.1:5877/f4cc3b61-ff21-46c3-99e2-c44712d75584
For help, see: https://nodejs.org/en/docs/inspector
[74401:1220/124848.313735:INFO:CONSOLE(221)] "%c INFO color: #33f Starting worker process with pid 74486 (type: parcelWatcher, window: 1).", source: vscode-file://vscode-app/Users/daimms/dev/Microsoft/vscode/out/vs/platform/log/common/log.js (221)
2021-12-20 12:48:48.881 Code - OSS Helper (Renderer)[74462:6003175] CoreText note: Client requested name ".NewYork-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
2021-12-20 12:48:48.881 Code - OSS Helper (Renderer)[74462:6003175] CoreText note: Set a breakpoint on CTFontLogSystemFontNameRequest to debug.
[74401:1220/124848.979259:INFO:CONSOLE(104)] "%c[IPC Library: Pty Host] %c%c INFO color: blue color:  color: #33f Persistent process "1": Replaying 224 chars and 1 size events", source: vscode-file://vscode-app/Users/daimms/dev/Microsoft/vscode/out/vs/base/common/console.js (104)
2021-12-20 12:49:07.891 Code - OSS Helper (Renderer)[74462:6003175] CoreText note: Client requested name ".NewYork-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
2021-12-20 12:49:13.147 Code - OSS Helper (Renderer)[74462:6003175] CoreText note: Client requested name ".NewYork-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
Received signal 11 SEGV_MAPERR 000000000000
 [0x00011f3b8679]
 [0x0001224f4473]
 [0x000122510af9]
 [0x7ff8087f7e2d]
 [0x7ff84a010000]
 [0x00011e04b161]
 [0x00011edb4b0b]
 [0x00011f51a9f1]
 [0x00011f51cf30]
 [0x00011f5255ee]
 [0x00011f51cec5]
 [0x00011f516ff4]
 [0x00011f5365b5]
 [0x00011f37429c]
 [0x00011f38c576]
 [0x00011f3c4580]
 [0x00011f3c0b62]
 [0x00011f3c3d9f]
 [0x7ff8088a984d]
 [0x7ff8088a97b5]
 [0x7ff8088a9534]
 [0x7ff8088a7f6b]
 [0x7ff8088a752d]
 [0x7ff8114c53e1]
 [0x7ff8114c5137]
 [0x7ff8114c4ed5]
 [0x7ff80b2d28f0]
 [0x7ff80b2d0f5c]
 [0x7ff80b2c3359]
 [0x00011f3c4c26]
 [0x00011f3c387b]
 [0x00011f38d94f]
 [0x00011f35ffac]
 [0x00011ece4c11]
 [0x00011ece6392]
 [0x00011ece2294]
 [0x00011e1388a7]
 [0x00011e1383a8]
 [0x00011e1374f6]
 [0x00011e1375e2]
 [0x00011da0e766]
 [0x00010eab87e6]
 [0x0001157184fe]
 [0x000000000000]
 [0x00010eab7000]
[end of stack trace]
[1220/124919.589647:WARNING:crash_report_exception_handler.cc(240)] UniversalExceptionRaise: (os/kern) failure (5)
Segmentation fault: 11

@Tyriar
Copy link
Member Author

Tyriar commented Jan 4, 2022

Tracking the user activation problem in #140106

@Tyriar
Copy link
Member Author

Tyriar commented Aug 3, 2022

#157008

@Tyriar Tyriar closed this Aug 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2022
@Tyriar Tyriar deleted the tyriar/ligatures2 branch December 15, 2022 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant