Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Install Extension' searches by name, but only shows displayName, description, and version in the results #1441

Closed
jwulf opened this issue Dec 18, 2015 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@jwulf
Copy link

jwulf commented Dec 18, 2015

In #140 (comment) @egamma recommends installing @dbaeumer's vscode-eslint extension.

While doing this, I notice that I can search for vscode-eslint in the Install Extensions dialog. I find the correct extension, but the results pane does not show me the vscode-eslint that I searched for (name in package.json). It shows displayName, description, version, and publisher.

I was left wondering if that was the right package, because it said ESLint, and I couldn't see vscode-eslint anywhere.

In the case where a user searches on name, and VS Code finds a match, if the results pane contained feedback that the package listed is the right package, it would be good.

An idea: Maybe show name in the results if the match was on name?

I've attached a screen shot - hope that clarifies what I'm talking about.

Thanks!

screen shot 2015-12-18 at 7 31 05 pm

@jwulf jwulf changed the title 'Install Extension' searches by name, but only show displayName, description, and version 'Install Extension' searches by name, but only shows displayName, description, and version in the results Dec 18, 2015
@egamma egamma added install-update VS Code installation and upgrade system issues important Issue identified as high-priority bug Issue identified by VS Code Team member as probable bug labels Dec 18, 2015
@egamma
Copy link
Member

egamma commented Dec 18, 2015

@jwulf - convinced after watching your video 😄

@egamma egamma added this to the Jan 2016 milestone Dec 18, 2015
@joaomoreno
Copy link
Member

Showing all attributes in the UI will simply make it cluttered. We still let you filter on the underlying ID since that is a nice thing to do.

@egamma, why important?

@egamma
Copy link
Member

egamma commented Jan 4, 2016

@joaomoreno this video illustrates that this results in confusion.

@joaomoreno
Copy link
Member

Ok, what's your pick?

  • Do not show readable extension name, but extension ids in the UI
  • Show both readable name and id, for every extension in the UI
  • Stop filtering on the extension id

Also, removing the important flag, as this hardly seems to be.

@joaomoreno joaomoreno removed important Issue identified as high-priority install-update VS Code installation and upgrade system issues labels Jan 4, 2016
@jwulf
Copy link
Author

jwulf commented Jan 4, 2016

What about option 4: "show the extension id when that is what was searched and matched"

If they didn't search on extension id, no need to show it. 

If they searched on extension id and we found matches, then show it. 

In other words: have the behaviour match the user's intent and expected context. 

Or more simply: show them what they are looking for. 


Sent from Mailbox

On Tue, Jan 5, 2016 at 12:58 AM, João Moreno [email protected]
wrote:

Ok, what's your pick?

  • Do not show readable extension name, but extension ids in the UI
  • Show both readable name and id, for every extension in the UI

- Stop filtering on the extension id

Reply to this email directly or view it on GitHub:
#1441 (comment)

@joaomoreno
Copy link
Member

I don't really like that solution since it would make labels come in and out of the view as you type and poses the following questions: Where to show it? Do we replace the readable name with it? Do we append to it?

@jwulf
Copy link
Author

jwulf commented Jan 5, 2016

Great questions. 

One possibility:

Show only the names while the user is typing, then when the user stops typing for a (specified delay period), make a decision about what to show. 

That addresses the labels coming in and out of view. 

What about having the Name as a tooltip, and it could only be a tooltip for items where the match was made on name. 

That would be kind of like Google's "Why am I seeing this ad?" pattern. 


Sent from Mailbox

On Tue, Jan 5, 2016 at 1:59 AM, João Moreno [email protected]
wrote:

I don't really like that solution since it would make labels come in and out of the view as you type and poses the following questions: Where to show it? Do we replace the readable name with it? Do we append to it?

Reply to this email directly or view it on GitHub:
#1441 (comment)

@joaomoreno
Copy link
Member

How about a tooltip over every extension's readable name that would display its id? Would that help?

@jwulf
Copy link
Author

jwulf commented Jan 6, 2016

I think so.

@egamma
Copy link
Member

egamma commented Jan 6, 2016

+1

joaomoreno added a commit that referenced this issue Jan 6, 2016
@bpasero bpasero assigned dbaeumer and unassigned joaomoreno Jan 29, 2016
@dbaeumer dbaeumer added the verified Verification succeeded label Jan 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants