Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature help should be triggered when entering placeholders following trigger chars #164310

Closed
sam-mccall opened this issue Oct 22, 2022 · 4 comments
Assignees
Labels
editor-parameter-hints Function, method and class parameter hint widget feature-request Request for new features or functionality suggest IntelliSense, Auto Complete

Comments

@sam-mccall
Copy link

When a completion provider returns a snippet like atan2(${1:y}, ${2:x}), the user should see signature help when editing the parameters.
VSCode could trigger signature help automatically when entering these placeholders (given that ( and , are trigger characters) but does not do so.
Other editors do this and provide noticeably a better signature-help flow with the same language servers (e.g. Neovim+nvim-cmp+lsp_signature.nvim).

This is a near-dupe of #78806 which is locked, I believe the resolution wasn't right.
It was suggested that providers should attach a command to the completion item to trigger signature help. However this doesn't really achieve the goal: will only fire when first entering the first parameter placeholder for the first time, it will not trigger when tabbing to other parameters, or when returning to the first one.

Moreover that idea requires changes to LSP, various language servers and other plugins, which means it may be a long time until it is available to users (3 years so far), and doesn't seem necessary.

@sam-mccall
Copy link
Author

Correction: if signature help is opened (e.g. with the command), tabbing to a second parameter does seem to keep the signature help open and refresh it.
However the signature help window often disappears while editing (inlay hint updates seem to do this) and doesn't reappear when moving to an eligible tabstop.

sam-mccall added a commit to sam-mccall/vscode-clangd that referenced this issue Oct 22, 2022
…iate.

As recommended in microsoft/vscode#78806
This is an incomplete fix but better than nothing.
Also files microsoft/vscode#164310 in case
VSCode can improve the behavior here.

fixes clangd#390
@jrieken jrieken added feature-request Request for new features or functionality suggest IntelliSense, Auto Complete editor-parameter-hints Function, method and class parameter hint widget labels Dec 5, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Dec 5, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-parameter-hints Function, method and class parameter hint widget feature-request Request for new features or functionality suggest IntelliSense, Auto Complete
Projects
None yet
Development

No branches or pull requests

3 participants