Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove navigation addon #170988

Closed
meganrogge opened this issue Jan 10, 2023 · 2 comments · Fixed by #173154
Closed

Remove navigation addon #170988

meganrogge opened this issue Jan 10, 2023 · 2 comments · Fixed by #173154
Assignees
@Tyriar
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label
Milestone
February 2023

Comments

@meganrogge
Copy link
Contributor

Making this so we remember to remove a bunch of code when #169853 is merged
@meganrogge meganrogge added debt Code quality issues terminal General terminal issues that don't fall under another label labels Jan 10, 2023
@meganrogge meganrogge added this to the January 2023 milestone Jan 10, 2023
@Tyriar
Copy link
Member

Tyriar commented Jan 10, 2023

Let's keep it in for at least an iteration to be safer in case users depend on it.

@Tyriar Tyriar modified the milestones: January 2023, February 2023 Jan 10, 2023
@meganrogge meganrogge mentioned this issue Jan 23, 2023
Closed
@meganrogge
Copy link
Contributor Author

IMO, we need to fix this or remove it along with the hint - otherwise, that will be confusing and frustrating for users. #172011

@meganrogge meganrogge mentioned this issue Jan 23, 2023
Closed
4 tasks
@meganrogge meganrogge mentioned this issue Feb 1, 2023
Closed
@Tyriar Tyriar mentioned this issue Feb 2, 2023
Merged
Tyriar added a commit that referenced this issue Feb 2, 2023
@Tyriar
Remove terminal navigation mode
a1a2a41 
Fixes #170988
@Tyriar Tyriar mentioned this issue Feb 2, 2023
Merged
meganrogge added a commit that referenced this issue Feb 3, 2023
@Tyriar @meganrogge
Remove terminal navigation mode (#173154)
97deded 
Fixes #170988

Co-authored-by: Megan Rogge <[email protected]>
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 3, 2023
c-claeys pushed a commit to c-claeys/vscode that referenced this issue Feb 16, 2023
@Tyriar @meganrogge @c-claeys
Remove terminal navigation mode (microsoft#173154)
0652744 
Fixes microsoft#170988

Co-authored-by: Megan Rogge <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

Remove terminal navigation mode microsoft/vscode
3 participants
@Tyriar @meganrogge @vscodenpa