Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to resolve command in codeAction/resolve #176705

Closed
RblSb opened this issue Mar 10, 2023 · 1 comment · Fixed by #178535
Closed

Allow to resolve command in codeAction/resolve #176705

RblSb opened this issue Mar 10, 2023 · 1 comment · Fixed by #178535
Assignees
@mjbvz
Labels
api author-verification-requested Issues potentially verifiable by issue author editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2023

Comments

@RblSb
Copy link

RblSb commented Mar 10, 2023

I tried to make simple code action thats adds function signature argument with type, generated from function call. So i need to asynchronously compute argument type, then make edit, then call command with arguments with edit position to select added function argument.
But you cannot resolve edit and command because of vscode limitation:
#106410 (comment)
So i cannot make code action that will be added to context menu without computation lag, since codeAction/resolve is limited only to edits.
I hope that @jrieken can understand many use cases from allowing to lazily resolve edit and command in code actions, and allow to change them both in resolve. This should be minor change with removing such limitation, and this is already allowed by lsp spec?
@mjbvz mjbvz added feature-request Request for new features or functionality api editor-code-actions Editor inplace actions (Ctrl + .) labels Mar 10, 2023
@mjbvz mjbvz added this to the Backlog milestone Mar 10, 2023
@mjbvz mjbvz modified the milestones: Backlog, April 2023 Mar 28, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 28, 2023
@mjbvz
Add initial support for move to file
f0990c1 
Fixes microsoft#176705
For microsoft/TypeScript#53542
@mjbvz mjbvz mentioned this issue Mar 28, 2023
Merged
mjbvz added a commit that referenced this issue Mar 28, 2023
@mjbvz
Add initial prototype for JS/TS move to file refactoring (#178535)
ce00cd7 
Add initial support for move to file

Fixes #176705
For microsoft/TypeScript#53542
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 28, 2023
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Apr 24, 2023
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@RblSb, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 3a69e15 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Apr 24, 2023
@connor4312 connor4312 added the verified Verification succeeded label Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api author-verification-requested Issues potentially verifiable by issue author editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

Add initial prototype for JS/TS move to file refactoring mjbvz/vscode
4 participants
@connor4312 @RblSb @mjbvz @vscodenpa