Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve notebook.output.fontFamily wording #177844

Closed
Tyriar opened this issue Mar 21, 2023 · 2 comments
Closed

Improve notebook.output.fontFamily wording #177844

Tyriar opened this issue Mar 21, 2023 · 2 comments
Assignees
@rebornix @amunger
Labels
insiders-released Patch has been released in VS Code Insiders notebook-output polish Cleanup and polish issue
Milestone
March 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 21, 2023

Testing #177719

This doesn't read well to me:

image

Suggestion:

The font family of the output text within notebook cells. When unset, #editor.fontFamily# is used.
@Tyriar
Copy link
Member Author

Tyriar commented Mar 21, 2023

Similar improvements could be made to the other settings. The "for...for" in particular:

image

@rebornix
Copy link
Member

Thanks for the feedback, the suggestion looks good.

@rebornix rebornix added polish Cleanup and polish issue notebook-output labels Mar 21, 2023
@rebornix rebornix added this to the March 2023 milestone Mar 21, 2023
rebornix added a commit that referenced this issue Mar 21, 2023
@rebornix
💄 Fix #177844. output settings wording.
278a331
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@amunger amunger

Labels
insiders-released Patch has been released in VS Code Insiders notebook-output polish Cleanup and polish issue
Projects
None yet
Milestone
March 2023
Development

No branches or pull requests
4 participants
@rebornix @amunger @Tyriar @vscodenpa