'Run Build Task' activating many extensions

[ulugbekna]

Description

Running the command Tasks: Run Build Task is activating various unnecessary extensions

TRACE KeybindingService#dispatch ⇧⌘B [ Will dispatch command workbench.action.tasks.build ]
TRACE CommandService#executeCommand workbench.action.tasks.build
TRACE onWillActivateByEvent:  onTaskType:grunt
TRACE onWillActivateByEvent:  onTaskType:gulp
TRACE onWillActivateByEvent:  onTaskType:jake
TRACE onWillActivateByEvent:  onTaskType:npm
TRACE onWillActivateByEvent:  onTaskType:typescript
TRACE onWillActivateByEvent:  onTaskType:eslint
TRACE onWillActivateByEvent:  onTaskType:docker-build
TRACE onWillActivateByEvent:  onTaskType:docker-run
TRACE onWillActivateByEvent:  onTaskType:docker-compose
TRACE onWillActivateByEvent:  onTaskType:dune
TRACE onWillActivateByEvent:  onTaskType:cargo

Version

Version: 1.80.0-insider
Commit: a5727468f373af49f785a94e13e7a2890a1097af
Date: 2023-06-23T05:59:29.272Z
Electron: 22.3.13
ElectronBuildId: 21803499
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 22.5.0

[meganrogge]

This is by design - we have to activate any extensions which contribute tasks to fetch the build tasks, if any, that they contribute.

[ulugbekna]

we have to activate any extensions which contribute tasks to fetch the build tasks, if any, that they contribute.

is that the case even if there's a default task configured?

I have a suspicion something has changed because building, for example, vscode repo or just a new extension repo with cmd+shift+b didn't use to activate, e.g., ocaml extension (and there weren't any changes on the ocaml ext side). I would imagine we in general don't need to activate many extensions if there's a default build task?

Screen.Recording.2023-06-25.at.12.50.09.mov

[meganrogge]

Note to self - this was happening before the change where we resolve workspace tasks

[meganrogge]

This is happening because we check for glob tasks as the default - since we aren't sure which it might be, we have to call getWorkspaceTasks with no args and that activates all task providers

vscode/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts

Lines 2942 to 2957 in e55c822

	if (absoluteURI) {
	const workspaceFolder = this._contextService.getWorkspaceFolder(absoluteURI);
	// fallback to absolute path of the file if it is not in a workspace or relative path cannot be found
	const relativePath = workspaceFolder?.uri ? (resources.relativePath(workspaceFolder.uri, absoluteURI) ?? absoluteURI.path) : absoluteURI.path;
	taskGroupTasks = await this._findWorkspaceTasks((task) => {
	const currentTaskGroup = task.configurationProperties.group;
	if (currentTaskGroup && typeof currentTaskGroup !== 'string' && typeof currentTaskGroup.isDefault === 'string') {
	return (currentTaskGroup._id === taskGroup._id && glob.match(currentTaskGroup.isDefault, relativePath));
	}
	return false;
	});
	}
	const handleMultipleTasks = (areGlobTasks: boolean) => {

vscode/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts

Line 696 in e55c822

const tasks = await this.getWorkspaceTasks();

[meganrogge]

this originated here #141230

seems like not worth it in most cases. this should probably behind a setting