Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reordering editor tabs in-between tabs and make consistent across the workbench #203441

Closed
benibenj opened this issue Jan 25, 2024 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan workbench-dnd Drag-and-drop issues workbench-tabs VS Code editor tab issues
Milestone

Comments

@benibenj
Copy link
Contributor

benibenj commented Jan 25, 2024

When you currently reorder editor tabs we change the background color of the tab you are hovering over, this does not make it very easy to understand where the tab will be placed when the user drops it.

Code_-_Insiders_AFQpdbKTwl

In future we would like to indicate where the tab will be placed by rendering an indicator between the tabs where it will be placed.

Code_-_OSS_WIa6jFJOZx

Further improvements could include changing the position of the dragged item in relation to the mouse pointer (top left of the editor tab is placed on the mouse) or changing the rendering of the dragged item. The reason for this is that the rendering of the dragged tab can make it harder to see the drop indicator.

@benibenj benibenj added feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues labels Jan 25, 2024
@benibenj benibenj added this to the Backlog milestone Jan 25, 2024
@benibenj benibenj self-assigned this Jan 25, 2024
@benibenj benibenj changed the title Support reordering editor tabs in-between tabs and make consistent around the workbench Support reordering editor tabs in-between tabs and make consistent across the workbench Jan 25, 2024
@bpasero bpasero added the workbench-dnd Drag-and-drop issues label Jan 25, 2024
@bpasero
Copy link
Member

bpasero commented Jan 30, 2024

One thing I only now realise when playing around with #203681 is that we do make it harder now for a tab to be dragged to the location of another tab.

Previously you could just move it to the far left or right edge:

Recording 2024-01-30 at 06 48 16

Now you need to move it all the way:

Recording 2024-01-30 at 06 49 22

This probably deserves a UX discussion with more people involved. I am not sure if this is actually a problem, unless we hand it off to more people to try it out.

Tagging some more people for thoughts: @hbons @joaomoreno ?

@benibenj
Copy link
Contributor Author

benibenj commented Feb 1, 2024

Completed with #203681. Still open to feedback

@benibenj benibenj closed this as completed Feb 1, 2024
@bpasero bpasero modified the milestones: Backlog, February 2024 Feb 1, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan workbench-dnd Drag-and-drop issues workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

3 participants