Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tab Drag and Drop Indicator #203681

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Added Tab Drag and Drop Indicator #203681

merged 8 commits into from
Feb 1, 2024

Conversation

benibenj
Copy link
Contributor

@benibenj benibenj commented Jan 29, 2024 •
edited
Loading

This PR introduces a new feature that adds a visual indicator for tab drag and drop operations. The indicator is displayed between tabs to signify that a tab can be dropped in that location. This enhancement improves the user experience by providing clear visual feedback during tab rearrangement operations. #203441

@benibenj benibenj requested a review from bpasero January 29, 2024 11:12
@benibenj benibenj self-assigned this Jan 29, 2024
@benibenj benibenj enabled auto-merge (squash) January 29, 2024 11:12
@vscodenpa vscodenpa added this to the February 2024 milestone Jan 29, 2024
bpasero
bpasero requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my brief testing this works already pretty cool 👍

One thing I noticed is that in high contrast theme the drop feedback (dashed borders) seems to stick, not sure we even want it with the new feedback?

Screenshot 2024-01-30 at 06 32 00

src/vs/workbench/common/theme.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts Outdated Show resolved Hide resolved
@bpasero bpasero mentioned this pull request Jan 30, 2024
Closed
@benibenj benibenj requested a review from bpasero January 31, 2024 11:48
@benibenj benibenj disabled auto-merge January 31, 2024 11:48
@benibenj benibenj enabled auto-merge February 1, 2024 07:57
@benibenj benibenj dismissed bpasero’s stale review February 1, 2024 07:57

feedback has been considered

@benibenj benibenj merged commit 2c52868 into main Feb 1, 2024
6 checks passed
@benibenj benibenj deleted the benibenj/ytterbic-rooster branch February 1, 2024 08:01
@jirsbek jirsbek mentioned this pull request Mar 6, 2024
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero left review comments

@lszomoru lszomoru lszomoru approved these changes

Assignees

@benibenj benibenj

Labels
None yet
Projects
None yet
Milestone
February 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@benibenj @bpasero @lszomoru @vscodenpa