Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any change to a notebook after a Move Cell operation is still recorded as a Move Cell operation. #208565

Closed
bhavyaus opened this issue Mar 25, 2024 · 1 comment · Fixed by #208631
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders notebook notebook-undo-redo verified Verification succeeded
Milestone

Comments

@bhavyaus
Copy link
Collaborator

bhavyaus commented Mar 25, 2024

Testing #208266

See gif below:

Recording 2024-03-25 at 13 57 44

@DonJayamanne
Copy link
Contributor

Yeah, this will be challenging,
Current design is to always collapse all new edits with the previous edit operations.
However if we stop collapsing all edits, then the only other alternative is to always display each save as File Saved as was done here #208053

I.e. all operations will show up consistently as File Saved
Thoughts @rebornix /cc
I think that would be better than having a mix of Move Cell, File Saved, I.e. File Saved always is consistent and simple.
We can explore ways to make this more fine grained later,

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Mar 25, 2024
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 25, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 26, 2024
@bhavyaus bhavyaus added the verified Verification succeeded label Mar 28, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders notebook notebook-undo-redo verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants