Show 'File saved' not Cell Metadata Updated
#208053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #207968
Work around for better Notebook Timeline entries
In notebooks when adding a cell, we (built in ipynb serializer extension) performs additional edits as a side effect of adding a cell
Insert Cell
in Timeline as the last edit operations isUpdate Cell Metadata
Cell Metadata Updated
is not a user friendly operation we would prefer to replace this label in favour ofFile Saved
(as is done today for Text Buffer edits)Looking at how this is done for text editor, we need to ensure the
code === 'undoredo.textBufferEdit'
@bpasero
Wanted to check if this simple work around is sufficient, or whether we should come up with a different strategy.
We want notebook edit operations to end up in the line
return undefined
, thats the code path that leads toFile Saved
in the timeline view.