Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open a folder with the simple file dialog #208937

Closed
amunger opened this issue Mar 27, 2024 · 5 comments
Closed

Can't open a folder with the simple file dialog #208937

amunger opened this issue Mar 27, 2024 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@amunger
Copy link
Contributor

amunger commented Mar 27, 2024

Steps to Reproduce:

  1. set "files.simpleDialog.enable": true
  2. press ctrl+k ctrl+o (workbench.action.files.openFolder) to open a folder
  3. find a directory and press enter, press the ok
    🐛 folder is not opened

Recording 2024-03-27 at 10 42 36

@amunger amunger added the important Issue identified as high-priority label Mar 27, 2024
@amunger
Copy link
Contributor Author

amunger commented Mar 27, 2024

I'm on windows, does not repro in stable

@connor4312
Copy link
Member

connor4312 commented Mar 27, 2024

This also affects remotes where the simple file picker is always used

@connor4312
Copy link
Member

I poked into it to try to avoid a candidate if the fix was simple, but the logic is kind of tricky. With a change in the last Insiders we always end up here

return await this.updateItems(valueUri) ? UpdateResult.UpdatedWithTrailing : UpdateResult.Updated;

which makes us no-op the accept

// If the items have updated, don't try to resolve

@FannoFlow1
Copy link

I thought I was going crazy. Thank you for reporting this! Wild bug to encounter just trying to open a folder.

@amunger amunger added this to the March 2024 milestone Mar 28, 2024
@amunger
Copy link
Contributor Author

amunger commented Mar 28, 2024

adding to march milestone to try to ensure it is looked into

@deepak1556 deepak1556 added the bug Issue identified by VS Code Team member as probable bug label Apr 2, 2024
@alexr00 alexr00 added the candidate Issue identified as probable candidate for fixing in the next release label Apr 2, 2024
alexr00 added a commit that referenced this issue Apr 2, 2024
alexr00 added a commit that referenced this issue Apr 2, 2024
alexr00 added a commit that referenced this issue Apr 2, 2024
alexr00 added a commit that referenced this issue Apr 2, 2024
@alexr00 alexr00 closed this as completed Apr 2, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 2, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants