Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting window.customTitleBarVisibility to windowed in web hides title bar #209159

Closed
grgar opened this issue Mar 29, 2024 · 1 comment · Fixed by #209162
Closed

Setting window.customTitleBarVisibility to windowed in web hides title bar #209159

grgar opened this issue Mar 29, 2024 · 1 comment · Fixed by #209162
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@grgar
Copy link
Contributor

grgar commented Mar 29, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.87.2
  • OS Version: macOS 14.4.1

Steps to Reproduce:

  1. Open https://vscode.dev

  2. Set user settings.json to

    {
        "window.customTitleBarVisibility": "windowed"
    }
  3. Title bar is hidden.

Title bar should never be hidden by this option in VS Code Web. This configuration option is considered unknown and should have no effect in web. Other values ("auto", "never") correctly have no effect.

Screen.Recording.2024-03-29.at.9.32.11.PM.mov

This causes problems when using settings sync from desktop because hiding the title bar is fine on desktop where the menu bar is still accessible, but the menu bar is part of the title bar in web and makes it inaccessible.

Version: 1.87.2
Commit: 863d258
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.4 Safari/605.1.15
Embedder: vscode.dev

grgar added a commit to grgars/vscode that referenced this issue Mar 29, 2024
…soft#209159)

Fix microsoft#209159 by not changing behaviour on this unregistered (on web) configuration option.
@grgar
Copy link
Contributor Author

grgar commented Mar 29, 2024

It is already impossible to hide the title bar on web in other ways, e.g. Hide Custom Title Bar command, since the configuration option is unregistered.

Unable to write to User Settings because window.customTitleBarVisibility is not a registered
configuration.

Raised a PR #209162 to no longer try to read this unregistered configuration option on web.

@benibenj benibenj self-assigned this Apr 8, 2024
@benibenj benibenj added this to the April 2024 milestone Apr 9, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 9, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants