Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable extension spell checking/fixes in the comments editor #209508

Closed
mjbvz opened this issue Apr 4, 2024 · 2 comments
Closed

Enable extension spell checking/fixes in the comments editor #209508

mjbvz opened this issue Apr 4, 2024 · 2 comments
Assignees
@mjbvz
Labels
api comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2024

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 4, 2024 •
edited
Loading

Tracks allowing extensions to contribute spell checking and code actions to the comments input widget

@alexr00 should be fairly similar to the work I did enabling this for scm input so going to take a quick look. Could also allow enabling other md language features in the input, such as the paste to create link functionality
@mjbvz mjbvz self-assigned this Apr 4, 2024
mjbvz added a commit to mjbvz/vscode that referenced this issue Apr 4, 2024
@mjbvz
Expose comments input as text document
826b140 
Fixes https://github.com/microsoft/vscode-pull-request-github/issues/5875
For microsoft#209508

Exposes comment input editors as text documents that extensions can see. Enables a few features in them too such as 'paste as' and 'drop into'
@mjbvz mjbvz mentioned this issue Apr 4, 2024
Merged
@alexr00 alexr00 added this to the April 2024 milestone Apr 5, 2024
alexr00 added a commit that referenced this issue Apr 5, 2024
@mjbvz @alexr00
Expose comments input as text document (#209512)
8cae0f0 
* Expose comments input as text document

Fixes https://github.com/microsoft/vscode-pull-request-github/issues/5875
For #209508

Exposes comment input editors as text documents that extensions can see. Enables a few features in them too such as 'paste as' and 'drop into'

* Small fixes

* Enable markers in comments

* Fix async

* Fix comment buttons on the top

---------

Co-authored-by: Alex Ross <[email protected]>
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 5, 2024

Should be working end to end once streetsidesoftware/vscode-spell-checker#3151 is published

@mjbvz mjbvz closed this as completed Apr 5, 2024
@mjbvz mjbvz added feature-request Request for new features or functionality api comments Comments Provider/Widget/Panel issues labels Apr 5, 2024
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Apr 22, 2024
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 22, 2024

To verify this:

  1. Run the code actions sample: https://github.com/microsoft/vscode-extension-samples/tree/main/code-actions-sample
  2. Open a comments input and type :). Confirm you get quick fix on |:) where | is the cursor. The fix should replace :) with an emoji
  3. Type emoji and confirm you see a diagnostic and quick fix that opens some documentation

@benibenj benibenj added the verified Verification succeeded label Apr 23, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2024
Development

No branches or pull requests
3 participants
@mjbvz @alexr00 @benibenj