Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Minimal error renderer #210942

Closed
3 tasks done
amunger opened this issue Apr 22, 2024 · 0 comments
Closed
3 tasks done

Test: Minimal error renderer #210942

amunger opened this issue Apr 22, 2024 · 0 comments

Comments

@amunger
Copy link
Contributor

amunger commented Apr 22, 2024

Refs: #200253

Complexity: 3

Create Issue


Pre-requisites - If you don't have python set up to run notebooks

  1. ensure python is installed on your machine
  2. open a workspace where you will be running tests for this TPI
  3. Create: new jupyter notebook and run print(1) in a cell.
    a. If the cell runs successfully, you're already set up, otherwise...
  4. The kernel picker should open, select "Python Environments..." -> "Create Python Environment..." -> select venv or conda, and whichever version you'd like.

A virtual environment should get created in your workspace with all necessary packages installed, and the cell should run successfully.

Test steps

  1. set "notebook.output.minimalErrorRendering": true
  2. run cells that produce errors. Here is one that creates a fairly long stack trace: (run %pip install pandas to install pandas first)
import pandas as pd

# create a dataframe with sample data
df = pd.DataFrame(
    {
        "Name": ["Alice", "Bob", "Charlie"],
        "Age": [25, 30, 35],
        "Gender": ["F", "M", "M"],
    }
)

column = getColumn(df, "wrong")
print(column)
  1. The error renderer should just display the error name and message, with an option to view the stack and a link to the error location if it is available (it should be for python).
  2. also try running cells with the setting disabled: "notebook.output.minimalErrorRendering": false, and make sure the error renderer looks ok
@amunger amunger added this to the April 2024 milestone Apr 22, 2024
@isidorn isidorn removed their assignment Apr 23, 2024
@aeschli aeschli removed their assignment Apr 23, 2024
@bhavyaus bhavyaus removed their assignment Apr 23, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants