Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error rendering should be unified across notebooks and editor #211068

Open
isidorn opened this issue Apr 23, 2024 · 1 comment
Open

Error rendering should be unified across notebooks and editor #211068

isidorn opened this issue Apr 23, 2024 · 1 comment
Assignees
Labels
notebook-output under-discussion Issue is under discussion for relevance, priority, approach

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 23, 2024

Testing #210942

I am not sure if the direction of rendering errors in a custom way in Notebooks is the best way forward.
Could we somehow re-use our rendering in the problems view? Or nudge the users towards the Problems view? Do we want to build two problem rendering solutions?

fyi @lszomoru @joaomoreno

Image

@amunger
Copy link
Contributor

amunger commented Apr 23, 2024

There is no problems matcher involved here, this is just the error output from the kernel process. Every kernel type can have it's own format, and they are very different between languages. If that still sounds like problem matchers would be a good fit, I'd definitely be interested in digging into that more, but I don't see them working here.

@rzhao271 rzhao271 added under-discussion Issue is under discussion for relevance, priority, approach notebook-output labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook-output under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants