Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make accessibility.signalOptions.delays an experimental setting and count usage #213623

Closed
isidorn opened this issue May 28, 2024 · 5 comments · Fixed by #213938
Closed

Make accessibility.signalOptions.delays an experimental setting and count usage #213623

isidorn opened this issue May 28, 2024 · 5 comments · Fixed by #213938
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented May 28, 2024

Testing #213344

I am not convinced about the need for accessibility.signalOptions.delays. Can we mark it as experimental, and make sure to opt in to telemetry for counting how many users use this.

My suggestion - if we see more than 20 users using it after a month then we can consider to finalize it. If not, we can remove.

fyi @hediet

@meganrogge
Copy link
Contributor

Roberto had suggested this should be configurable #204257 (comment)

It is a good idea to validate that with telemetry 👍🏼

@meganrogge meganrogge added polish Cleanup and polish issue accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug labels May 29, 2024
@meganrogge meganrogge added this to the May 2024 milestone May 29, 2024
@meganrogge
Copy link
Contributor

I am not able to see telemetry for specific properties of signalOptions. It doesn't look like there's a way to do this.

meganrogge added a commit that referenced this issue May 30, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label May 30, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 30, 2024
@connor4312 connor4312 added the verified Verification succeeded label May 30, 2024
@connor4312
Copy link
Member

@meganrogge I think you would have to manually event telemetry events for usage.

@meganrogge
Copy link
Contributor

thanks @connor4312, I tried that by adding:

	if (e.affectsConfiguration('accessibility.signalOptions')) {
				this._telemetryService.publicLog2<AccessibilitySignalDelayConfigurationChangeClassification>('changedSignalOptions');
			}

However, it still doesn't indicate of the specific property, delays, changed. 🤔

@meganrogge
Copy link
Contributor

@hediet another reason we should destructure the object #213618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants