Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: update patch doesn't show immediatly for locally installed extension #21375

Closed
aeschli opened this issue Feb 24, 2017 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 24, 2017

Verifying #17290

@sandy081
Copy link
Member

Good catch

sandy081 added a commit that referenced this issue Feb 28, 2017
jrieken pushed a commit that referenced this issue Feb 28, 2017
jrieken pushed a commit that referenced this issue Feb 28, 2017
@roblourens roblourens reopened this Mar 30, 2017
@roblourens
Copy link
Member

Still reproes for me using the original steps

@sandy081
Copy link
Member

@roblourens Thanks for validating it. There were some changes went in between which broke this. We had a workaround to query for both ids and names of extensions (instead of just names) to sync with gallery. Seems like only ids are respected but not names. In this case, vsix extension will not have id so it is not getting synced.

Above work around was introduced until Marketplace accepts case-insensitive names as queries. This got fixed in Market place. Removing the workaround fixes this issue.

@michelkaporin michelkaporin added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants