Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setActions happening unexpectedly causes filter input to lose focus #226661

Closed
meganrogge opened this issue Aug 26, 2024 · 0 comments · Fixed by #226667
Closed

setActions happening unexpectedly causes filter input to lose focus #226661

meganrogge opened this issue Aug 26, 2024 · 0 comments · Fixed by #226667
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@meganrogge
Copy link
Contributor

In insider's, use ctrl/cmd+f to focus any filter input box (problems, debug console, etc). 🐛 it receives focus then focus is lost.

focus.mov

updateActions is occurring very frequently. This calls setActions, which causes focus loss for all of the filter view input boxes.

primaryActionsToSet.forEach(action => {
this.actionBar.push(action, { icon: this.options.icon ?? true, label: this.options.label ?? false, keybinding: this.getKeybindingLabel(action) });
});

Image

@meganrogge meganrogge assigned meganrogge and unassigned sandy081 Aug 26, 2024
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Aug 26, 2024
@meganrogge meganrogge added this to the August 2024 milestone Aug 26, 2024
meganrogge added a commit that referenced this issue Aug 26, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 26, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 27, 2024
@roblourens roblourens added the verified Verification succeeded label Aug 29, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@roblourens @sandy081 @meganrogge and others