Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSAL] Adopt Broker flow in Microsoft Auth provider via MSAL-node #229431

Closed
TylerLeonhardt opened this issue Sep 23, 2024 · 0 comments · Fixed by #233739
Closed

[MSAL] Adopt Broker flow in Microsoft Auth provider via MSAL-node #229431

TylerLeonhardt opened this issue Sep 23, 2024 · 0 comments · Fixed by #233739
Assignees
Labels
feature-request Request for new features or functionality microsoft-authentication Issues with the Microsoft Authentication extension on-testplan
Milestone

Comments

@TylerLeonhardt
Copy link
Member

Docs here:
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/extensions/msal-node-extensions#usage---brokering

I talked to @deepak1556 about this one and the design we want to go with is having this native node module (@azure/msal-node-extensions) brought in to Core and have a worker/process that could process these requests. This way the ExtHost is not polluted with this native node module.

So the Microsoft Authentication extension:

  1. will talk to the Core window
  2. (optional) Core window talks to the Main Process
  3. and the Core window or Main process talks to this other process/worker

This could be API.. or maybe some other mechanism. API probably makes the most sense. Maybe a require interceptor if those still exist in a post-ESM world?

@TylerLeonhardt TylerLeonhardt added feature-request Request for new features or functionality microsoft-authentication Issues with the Microsoft Authentication extension labels Sep 23, 2024
@TylerLeonhardt TylerLeonhardt added this to the October 2024 milestone Sep 23, 2024
@TylerLeonhardt TylerLeonhardt self-assigned this Sep 23, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Nov 15, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 18, 2024
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Nov 22, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality microsoft-authentication Issues with the Microsoft Authentication extension on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant