-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSAL] Adopt Broker flow in Microsoft Auth provider via MSAL-node #229431
Labels
feature-request
Request for new features or functionality
microsoft-authentication
Issues with the Microsoft Authentication extension
on-testplan
Milestone
Comments
TylerLeonhardt
added
feature-request
Request for new features or functionality
microsoft-authentication
Issues with the Microsoft Authentication extension
labels
Sep 23, 2024
vs-code-engineering
bot
added
the
unreleased
Patch has not yet been released in VS Code Insiders
label
Nov 15, 2024
vs-code-engineering
bot
added
insiders-released
Patch has been released in VS Code Insiders
and removed
unreleased
Patch has not yet been released in VS Code Insiders
labels
Nov 18, 2024
TylerLeonhardt
added a commit
that referenced
this issue
Nov 21, 2024
TylerLeonhardt
added a commit
that referenced
this issue
Nov 21, 2024
vs-code-engineering
bot
removed
the
insiders-released
Patch has been released in VS Code Insiders
label
Nov 22, 2024
osortega
pushed a commit
that referenced
this issue
Nov 26, 2024
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
feature-request
Request for new features or functionality
microsoft-authentication
Issues with the Microsoft Authentication extension
on-testplan
Docs here:
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/extensions/msal-node-extensions#usage---brokering
I talked to @deepak1556 about this one and the design we want to go with is having this native node module (
@azure/msal-node-extensions
) brought in to Core and have a worker/process that could process these requests. This way the ExtHost is not polluted with this native node module.So the Microsoft Authentication extension:
This could be API.. or maybe some other mechanism. API probably makes the most sense. Maybe a require interceptor if those still exist in a post-ESM world?
The text was updated successfully, but these errors were encountered: