Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode 1.11.0 deleted most of key-binding on Fedora for Russian keyboard layout #24057

Closed
hzlmn opened this issue Apr 6, 2017 · 16 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded

Comments

@hzlmn
Copy link

hzlmn commented Apr 6, 2017

Hi, after updating to 1.11.0. Most of standard shortcuts not working for me like Ctrl+S, Ctrl+Z, Ctrl+F and so on.

Some of them can be attached with the new key binding menu but Ctrl+Z do not work even when I manually add it as a shortcut.

  • VSCode Version: 1.11.0
  • OS Version: Fedora 25
@dstrebkov
Copy link

Experiencing similar problems after today's upgrade on Ubuntu 16.04.

@lorenz
Copy link

lorenz commented Apr 6, 2017

Most keybindings work fine here (Ubuntu 16.10 on 1.11.0) but the xkbdmap option caps:swapescape does no longer work (it is just ignored in VSCode, works fine everywhere else) which makes Vim mode annoying.

@dstrebkov
Copy link

Just upgraded to 1.11.1, now I have the key bindings working properly.

@hzlmn
Copy link
Author

hzlmn commented Apr 6, 2017

@upokatik Not available yet for RH based distros 😢

@vshab
Copy link

vshab commented Apr 6, 2017

1.11.1 keywords still don't work. Fedora 25.

@chrmarti
Copy link
Collaborator

chrmarti commented Apr 6, 2017

Which keyboard layouts are you using?

@chrmarti chrmarti added the info-needed Issue requires more information from poster label Apr 6, 2017
@vshab
Copy link

vshab commented Apr 6, 2017

@chrmarti i have two system layouts - Russian and English. Shortcuts don't work in both.

@alexdima
Copy link
Member

alexdima commented Apr 6, 2017

@hzlmn What do you mean the shortcuts don't work? What do we detect when you press these key combinations?

To find out what we detect when you press a key combination

  • Open the define keybindings widget (Keyboard Prefereces -> go to keybindings.json)
  • Press the problematic key
  • Hover over the input field (this shows the raw values we get from the keydown event)
    image
  • The first three values for code, keyCode and key are the values coming in from the browser keydown event

Could you please also open an editor and run F1 > Developer: Inspect Keyboard Mappings, save the mappings to a file and attach them here?

@alexdima
Copy link
Member

alexdima commented Apr 6, 2017

@lorenz Could you please detail the way you have confgured your keyboard layout with caps:swapescape in a separate issue? It seems unrelated at this time with the issue the OP has.

@alexdima
Copy link
Member

alexdima commented Apr 6, 2017

@vshab Could you describe in greater detail the symptoms. Perhaps by giving a concrete example of what is going wrong. Is there a specific key combination that appears to malfunction?

@vshab
Copy link

vshab commented Apr 7, 2017

@alexandrudima i assume that after updating from vscode 1.10 char based shortcuts disappeared. Just as @hzlmn said: "Ctrl+S, Ctrl+Z, Ctrl+F and so on.". For example after editing the file and pressing Ctrl+S nothing happens and to save the changes I need to go File -> Save. However non-char shortcuts still work like Ctrl+Shift+. opens the settings or F11 toggles the fullscreen.
My OS is Fedora 25 with Russian locale by default with two keyboard layouts: ru and eng. Starting vscode in English by LANG=en_US code doesn't help. I just tried freshly installed OS and vscode in VM and the problem is still there.
Bellow are screenshots from menu showing the absence of default shortcuts when char keys are used (started as LANG=en_US code so interface language is English).
vscode

@vshab
Copy link

vshab commented Apr 7, 2017

@lexandrudima interesting observation - when i set the shortcut manually vscode shows Russian symbol even though selected layout is English. (ы and s are the same key)
vscode2
And then the shortcut goes into menu
vscode3
Created shortcut works well.

@alexdima alexdima changed the title vscode 1.11.0 deleted most of key-binding on Fedora vscode 1.11.0 deleted most of key-binding on Fedora for Russian keyboard layout Apr 10, 2017
@alexdima alexdima added important Issue identified as high-priority keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux keybindings VS Code keybinding issues candidate Issue identified as probable candidate for fixing in the next release and removed info-needed Issue requires more information from poster labels Apr 10, 2017
@alexdima alexdima added this to the March Recovery 2017 (2) milestone Apr 10, 2017
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Apr 10, 2017
@alexdima
Copy link
Member

Can someone please verify this works on the latest Insiders release (from today).

@vshab
Copy link

vshab commented Apr 11, 2017

@alexandrudima shortcuts work but the some hints are still in Russian which i think is not right.
2017-04-11 22-48-35
For example how Chromium does it:
2017-04-11 22-53-00

@alexdima
Copy link
Member

alexdima commented Apr 11, 2017

Yes, we render chords in a special format (in parens) because Electron menus cannot show chords. Let's track that in #24361. Thank you for verifying!

@jrieken
Copy link
Member

jrieken commented Apr 12, 2017

adding verified-label based on #24057 (comment)

@jrieken jrieken added the verified Verification succeeded label Apr 12, 2017
@egamma egamma removed the candidate Issue identified as probable candidate for fixing in the next release label Apr 12, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants