The "Color Theme" Affects the Color of Integrated Terminal

[shelvenzhou]

• VSCode Version: Code 1.12.1 (f6868fc, 2017-05-04T21:18:32.269Z)
• OS Version: Darwin x64 16.5.0
• Extensions:

Extension	Author	Version
beautify	HookyQR	1.0.2
gitignore	codezombiech	0.5.0
python	donjayamanne	0.6.4
code-runner	formulahendry	0.6.16
Go	lukehoban	0.6.61
cpptools	ms-vscode	0.11.0
vscode-icons	robertohuertasm	7.6.0

---

Steps to Reproduce:

[hungys]

Like #25986, I hope these themes (workbench, syntax, terminal) can be separately configured.

For example, zsh's agnoster isn't rendered really well with Monokai theme :/

[Dussed]

Having issues with zsh on Quiet Light theme too.. pretty much makes it unusable:

[Tyriar]

@shelvenzhou this is as designed, only some themes currently leverage the terminal theme options.

@Dussed does that also happen on the Light+ theme? It looks like you have black fg on a black bg on the left there which isn't meant to have particularly good contrast. You might want to create a new issue for this.

@hungys we'll keep the discussion for separate themes in #25986, but you've actually pointed out a bug: #26050

[hungys]

@Tyriar (cc @Dussed )
Actually zsh's popular theme agnoster also looks "not so good" on Quiet Light and Light+.

agnoster on VS Code (with Quiet Light/Light+ theme)

agnoster on iTerm2 (with Solarized Dark color scheme)

I know this is hard to compromise for fitting all the cases, so separating them may be one of the possible direction.

[Tyriar]

@hungys it looks like agnoster is designed for dark terminals? https://www.google.com/search?q=agnoster+theme&source=lnms&tbm=isch&sa=X&ved=0ahUKEwiUpuCzoNnTAhXosVQKHVERBdgQ_AUICigB&biw=1369&bih=799

For solarized light in particular, it will probably work but we don't theme the terminal just yet in those built-in themes. #26065

[hungys]

@Tyriar
Yes, I think so. But I have no idea about how many people would use dark editor with light terminal, or light editor with dark terminal, vice versa.

But I mean, even I'm a user who use dark theme for both terminal and editor, it is still hard to have all the theme perfectly fit my usage. (Check my previous Monokai+agnoster screenshots, it looks bad.) But maybe as you said, it's because the terminals have not been well-themed in those built-in themes.

[Tyriar]

@hungys I actually just added support for terminal.background and terminal.foreground theme keys so in the next Insiders build themes will be able to have the terminal look completely different to the panel and the rest of the workbench.

I'll leave this as designed for now, it may be worth revisiting the default light terminal theme at some point though.

[g5codyswartz]

Not sure if this is related but it showed up at the same time as the terminal colors being wonky
https://screencast.com/t/WUPhD3M68vVZ
Alert notifications are unreadable, I'm using the Monokai color theme

[Tyriar]

@g5codyswartz captured in #27040