Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning Label Difficult to Read in Monokai #27040

Closed
mattbierner opened this issue May 21, 2017 · 5 comments
Closed

Warning Label Difficult to Read in Monokai #27040

mattbierner opened this issue May 21, 2017 · 5 comments
Assignees
Labels
themes Color theme issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@mattbierner
Copy link
Contributor

screen shot 2017-05-18 at 11 18 55 pm

The bright yellow background makes the white text difficult to read

@Tyriar
Copy link
Member

Tyriar commented May 21, 2017

I believe this is a bug with the key it's using. Currently it's using the border key but I would expect it to use the background.

screen shot 2017-05-21 at 1 59 32 pm

@Tyriar Tyriar added themes Color theme issues under-discussion Issue is under discussion for relevance, priority, approach labels May 21, 2017
@bpasero bpasero added this to the Backlog milestone May 22, 2017
@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label May 22, 2017
@bpasero
Copy link
Member

bpasero commented May 22, 2017

This is not a bug in picking the key, this is just a case where the color does not really work. Feel free to change it.

@Tyriar
Copy link
Member

Tyriar commented May 22, 2017

@bpasero but why does the Warn/Info/Error badge background color in messages use the border color? It's also used as the border for input validation:

image

Better options imo would be to use the background color, use both the background and border or give the message box its own keys. The latter may be the best to support themes like Light+ that have a dark message box.

image

@bpasero
Copy link
Member

bpasero commented May 22, 2017

@Tyriar I did not want to introduce too many new things for the message list because I consider it a deprecated control that will be replaced soon enough with something else. When that happens we can have the theming discussion for it.

@bpasero bpasero removed the help wanted Issues identified as good community contribution opportunities label Nov 15, 2017
@bpasero
Copy link
Member

bpasero commented Nov 15, 2017

No plans to change this.

@bpasero bpasero closed this as completed Nov 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
themes Color theme issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants