Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore binding between DOM elements in VS Code to the smoke test DOM element selectors #27906

Closed
michelkaporin opened this issue Jun 2, 2017 · 1 comment
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone

Comments

@michelkaporin
Copy link
Contributor

michelkaporin commented Jun 2, 2017

Currently it is difficult to know if any of the DOM elements touched during a development work are used in the smoke test.

Continuation of #25291 (comment).

One example:
This following change lead to the smoke test failure because DOM element attribute was changed:
eac49a3
This attribute was used in the smoke test to grab the contents of SCM part in status bar:
0aec2d6

@michelkaporin michelkaporin added the engineering VS Code - Build / issue tracking / etc. label Jun 2, 2017
@michelkaporin michelkaporin added this to the Backlog milestone Jun 2, 2017
@michelkaporin michelkaporin self-assigned this Jun 2, 2017
@michelkaporin michelkaporin mentioned this issue Jun 2, 2017
29 tasks
@michelkaporin michelkaporin added the plan-item VS Code - planned item for upcoming label Jun 21, 2017
@michelkaporin
Copy link
Contributor Author

Exploration done and decision was made not to do any binding due to overhead and restrictions from the core code point of view.

Instead, log of smoke test failures should be created and maintained to understand common scenarios where tests fail because of loose binding or some other problems.

@michelkaporin michelkaporin removed the plan-item VS Code - planned item for upcoming label Jun 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

1 participant