Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated smoke test should disable all external extensions #27921

Closed
aeschli opened this issue Jun 2, 2017 · 1 comment
Closed

Automated smoke test should disable all external extensions #27921

aeschli opened this issue Jun 2, 2017 · 1 comment
Assignees
@michelkaporin
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone
Backlog

Comments

@aeschli
Copy link
Contributor

aeschli commented Jun 2, 2017

  • run the automated smoke test as described in Test: Automated Smoke Test #27456
  • I see from the opened windows that it contains external extension that I happened to have installed.

It would better if the smoke test, by default, turns off all extensions (run with --disable-extensions) in order to keep the test runs reliable and repeatable.
@michelkaporin michelkaporin added the engineering VS Code - Build / issue tracking / etc. label Jun 2, 2017
@michelkaporin michelkaporin added this to the Backlog milestone Jun 2, 2017
@michelkaporin
Copy link
Contributor

michelkaporin commented Jun 2, 2017 •
edited
Loading

Thanks, valid issue.
Rather than running with --disable-extensions I would prefer to run over clean extensions-dir with no extensions installed to be as close to the real user's way of working. Users don't run normally with --disable-extensions. Let me know if there is a specific reason why --disable-extensions is preferable.

Related: #27537

@michelkaporin michelkaporin mentioned this issue Jun 7, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@michelkaporin
Resolves microsoft#27921
3cd0895
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michelkaporin michelkaporin

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@michelkaporin @aeschli