Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated smoke tests depends on installed NodeJS #27922

Closed
aeschli opened this issue Jun 2, 2017 · 0 comments
Closed

Automated smoke tests depends on installed NodeJS #27922

aeschli opened this issue Jun 2, 2017 · 0 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Jun 2, 2017

Running tests...
npm ERR! Test failed.  See above for more details.

Running the tests with sudo showed the real problem:

/home/aeschli/workspaces/vscode/test/smoke/src/main.js:15
var testRepoLocalDir = path.join(process.cwd(), `${tempFolder}/vscode-smoketes
                                                ^
SyntaxError: Unexpected token ILLEGAL

Changing the version of the installed NodeJS to 7.5 fixed the issue

This could be fixed by avoiding ES6 syntax, or by adding a version check or by using electron run the tests.

@michelkaporin michelkaporin added the engineering VS Code - Build / issue tracking / etc. label Jun 2, 2017
@michelkaporin michelkaporin added this to the Backlog milestone Jun 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

2 participants