Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter does not find all errors that the browsers do #3140

Closed
justin-romano opened this issue Feb 18, 2016 · 7 comments
Closed

Linter does not find all errors that the browsers do #3140

justin-romano opened this issue Feb 18, 2016 · 7 comments
Assignees

Comments

@justin-romano
Copy link

a continue; that is not within a for should be an error.

@egamma egamma self-assigned this Feb 18, 2016
@egamma
Copy link
Member

egamma commented Feb 18, 2016

Given that there are now high quality linters for JS available (eslint, jshint) and there are also extensions for these linters with Code available, the will deprecate the built-in linter support in the next update.

Is this decision a problem for you? Can you try the eslint or jshint code extensions?

@justin-romano
Copy link
Author

What about Type Script? (not using it yet in this project but will)
But fair enough. Which is the best JS linter for vscode?

@egamma
Copy link
Member

egamma commented Feb 18, 2016

Which is the best JS linter for vscode?

Based on the download# of the extensions I'd say eslint, it has 25% more downloads.

What about Type Script? (not using it yet in this project but will)

Actually the JavaScript language support is powered by TS. TypeScript 1.8 will add more linting checks. If you want linting for TypeScript then we recommend to use tslint (for which there is also a Code extension.

@egamma egamma closed this as completed Feb 18, 2016
@justin-romano
Copy link
Author

Well i think you will kill code if you remove the linting.
Its i bit buggy but i uninstalled both alternatives in disgust.
They are awkward to configure and put big red lines under things that don't
matter like indenting and line endings.
You need something there but its just got to pick up real error. Something
you have done which will not run or just dumb things like missing var or
extra commas

On Fri, Feb 19, 2016 at 11:44 AM, Erich Gamma [email protected]
wrote:

Closed #3140 #3140.


Reply to this email directly or view it on GitHub
#3140 (comment).

Justin Romaine
Senior Systems Architect
Spark Dental Technology
[email protected]
ph 021 764 506
hm 09 445 9166

@justin-romano
Copy link
Author

You need this to be instantly useful for editing JS in my opinion :)

On Fri, Feb 19, 2016 at 12:07 PM, Justin Romaine [email protected]
wrote:

Well i think you will kill code if you remove the linting.
Its i bit buggy but i uninstalled both alternatives in disgust.
They are awkward to configure and put big red lines under things that
don't matter like indenting and line endings.
You need something there but its just got to pick up real error. Something
you have done which will not run or just dumb things like missing var or
extra commas

On Fri, Feb 19, 2016 at 11:44 AM, Erich Gamma [email protected]
wrote:

Closed #3140 #3140.


Reply to this email directly or view it on GitHub
#3140 (comment).

Justin Romaine
Senior Systems Architect
Spark Dental Technology
[email protected]
ph 021 764 506
hm 09 445 9166

Justin Romaine
Senior Systems Architect
Spark Dental Technology
[email protected]
ph 021 764 506
hm 09 445 9166

@egamma
Copy link
Member

egamma commented Feb 20, 2016

Well i think you will kill code if you remove the linting.

Thanks for your open feedback. I agree that the out of the box experience isn't that nice anymore. I'll try to some fixing/band-aid in the change notes docs for now. We can help with the setup of eslint by providing you with an action to create an eslintrc. At the same the Salsa team has started discussion on providing more warnings. Pls see: microsoft/TypeScript#6802.

@egamma
Copy link
Member

egamma commented Feb 20, 2016

Another option is that we bundle vscode-eslint

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants