Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet sometimes triggered at a bad time in PHP #32207

Closed
roblourens opened this issue Aug 10, 2017 · 2 comments
Closed

Emmet sometimes triggered at a bad time in PHP #32207

roblourens opened this issue Aug 10, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

<?php
foo::bar

Emmet will be triggered at the end of the line, but it seems like it shouldn't be. It's only when the :: is present. foo doesn't trigger it, but div does, which is correct.

There might have been other times when it showed up in PHP in an inappropriate place, will keep track of it...

@roblourens roblourens added the emmet Emmet related issues label Aug 10, 2017
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Aug 10, 2017
@ramya-rao-a ramya-rao-a added this to the August 2017 milestone Aug 10, 2017
@ramya-rao-a
Copy link
Contributor

Ideally we wouldnt want any emmet suggestions inside the <?php ?> block. But lets use #29354 for that discussion.

This current issue can be used for problems that can be fixed with easy regex solutions

@ramya-rao-a
Copy link
Contributor

Fixed with microsoft/vscode-emmet-helper@b8ab874

@roblourens roblourens added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants