Consider emmet completions from php extension

[ramya-rao-a]

See #29318 and #28286 (comment)

[jens1o]

Something new, would like to see it in action! :)

[ramya-rao-a]

@roblourens and I discussed this and it looks tough at the moment.
The helper is node module and php language service I believe is in php.
How do we make them talk to each other?

[jens1o]

What about websockets? For php I use this library: http://socketo.me/

[ramya-rao-a]

I am not familiar with that, but you are welcome to give it a try :)

[roblourens]

Spawning a node process from PHP is probably one solution. Making them talk to each other is easy, websockets not needed.

[ramya-rao-a]

cc @felixfbecker for this thoughts

[felixfbecker]

I think this is the same issue as HTML suggestions inside PHP in general (or CSS in HTML, or JS in HTML, or SQL in PHP). Imo requiring the language server to handle all possible embedded languages (and the possibly embedded languages inside the embedded language and so on) doesn't scale, because for N language servers you will each have to build and integrate M<N embedded languages, which can then have embedded languages again, so in the worst case you have to embed close to N^N language servers. For example, PHP needs to embed HTML, but HTML then needs to embed CSS and JS. The user also can't decide anymore what language server to use for the embedded languages. Overall, we would end up with a very inconsistent experience across languages.

A better approach I think is what I outlined in this thread: #670 (comment)
In summary, let the language server declare ranges of embedded languages to the client and then let the client (VS Code) use the appropriate language server for that range+language.

[bmewburn]

A little off topic but how do I turn emmet off? It's popping up everywhere and often the first selection in the list.

[ramya-rao-a]

@bmewburn set emmet.showExpandedAbbreviation to inMarkupAndStylesheetFilesOnly or never

However, we have refined the triggering of emmet suggestions in the latest Insiders (https://code.visualstudio.com/insiders). The same will be out in tomorrow's release of 1.15.1

So if you use emmet, I would suggest to set emmet.showExpandedAbbreviation back to always once 1.15.1 is released

[mcdado]

@ramya-rao-a I'm using 1.18.1 but I still need to set emmet.showExpandedAbbreviation to inMarkupAndStylesheetFilesOnly to solve this problem. Am I doing something wrong?

[ramya-rao-a]

@mcdado To solve which problem? Please share screenshots

[mcdado]

I admit that when I was figuring it out I thought it was happening exactly like here, with random keywords, but I now realize it is different, it happens with HTML keywords:

This is without inMarkupAndStylesheetFilesOnly.

[bmewburn]

With the intelephense extension my preference is to set emmet.showExpandedAbbreviation to inMarkupAndStylesheetFilesOnly as the extension will forward requests on to other extensions listening to html when outside of <?php ?>, meaning you will get emmet suggestions in a more appropriate context.

[ramya-rao-a]

@mcdado Can't do much for cases like that other than setting emmet.showExpandedAbbreviation to inMarkupAndStylesheetFilesOnly and relying on using tab for emmet instead by setting
emmet.triggerExpansionOnTab to true

@bmewburn I did not know that, good to know! Can you point me to the code that does that?

[bmewburn]

@ramya-rao-a here you go https://github.com/bmewburn/vscode-intelephense/blob/master/client/src/embeddedContentDocuments.ts 😄

[mcdado]

@bmewburn Indeed I'm using your awesome extension. I added again inMarkupAndStylesheetFilesOnly and it works great, indeed.

[vscodebot]

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!