Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peek view badges look different than other batches #36563

Closed
aeschli opened this issue Oct 19, 2017 · 6 comments
Closed

Peek view badges look different than other batches #36563

aeschli opened this issue Oct 19, 2017 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras

Comments

@aeschli
Copy link
Contributor

aeschli commented Oct 19, 2017

Version 1.18.0-insider
Commit 4b01451
Date 2017-10-19T08:25:22.140Z

image

@jrieken
Copy link
Member

jrieken commented Oct 23, 2017

Yeah, it is a different badge. Tho you are on a very old version as the latest version uses less round badges but more boxy badges as we do in the SCM viewlet

@jrieken jrieken added file-decorations under-discussion Issue is under discussion for relevance, priority, approach labels Oct 23, 2017
@aeschli
Copy link
Contributor Author

aeschli commented Oct 23, 2017

I'm on the latest.

image

@jrieken
Copy link
Member

jrieken commented Oct 23, 2017

So, do you mean the eggs in the peek view? That aren't SCM decorations but the old count badges telling you how many references have been found in a file

@aeschli
Copy link
Contributor Author

aeschli commented Oct 23, 2017

Yes, the badges in the peek view.

@jrieken jrieken added editor-contrib Editor collection of extras bug Issue identified by VS Code Team member as probable bug and removed file-decorations under-discussion Issue is under discussion for relevance, priority, approach labels Oct 25, 2017
@jrieken jrieken added this to the October 2017 milestone Oct 30, 2017
egamma pushed a commit that referenced this issue Oct 31, 2017
@bpasero
Copy link
Member

bpasero commented Nov 1, 2017

image

They still look a bit different to me though, the one in the search viewlet is much rounder compared to the one in the references widget. Also the size is different, which could have an impact.

@bpasero
Copy link
Member

bpasero commented Nov 2, 2017

Reopening based on my last comment to get confirmation that this is OK. I see the widget is used but maybe some styling is different.

@bpasero bpasero reopened this Nov 2, 2017
@bpasero bpasero added the verification-found Issue verification failed label Nov 2, 2017
@jrieken jrieken removed this from the October 2017 milestone Nov 2, 2017
@jrieken jrieken removed the verification-found Issue verification failed label Dec 8, 2017
@jrieken jrieken closed this as completed in 0f6a417 Dec 8, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras
Projects
None yet
Development

No branches or pull requests

3 participants