Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop debug button with node processes using useWSL: true doesn't kill node #38424

Closed
ericblade opened this issue Nov 15, 2017 · 7 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@ericblade
Copy link

  • VSCode Version: Code 1.18.0 (dcee220, 2017-11-08T21:22:49.932Z)
  • OS Version: Windows_NT x64 10.0.16299
  • Extensions:
Extension Author (truncated) Version
numbered-bookmarks ale 0.11.0
vscode-color ans 0.4.5
QML bbe 1.0.0
file-templates brp 1.2.0
npm-intellisense chr 1.3.0
path-intellisense chr 1.4.2
gitignore cod 0.5.0
vscode-eslint dba 1.4.3
vscode-instant-markdown dba 1.3.0
githistory don 0.2.3
gitlens eam 6.1.0
vscode-npm-script eg2 0.3.3
git-project-manager fel 1.4.0
vscode-npm fkn 3.3.0
auto-rename-tag for 0.0.15
code-sync gol 2.5.0
rest-client hum 0.16.0
redux-snippets jam 0.0.2
docthis joe 0.6.0
vscode-codemetrics kis 1.10.0
vscode-todo Mat 0.8.0
python ms- 0.8.0
cpptools ms- 0.14.2
csharp ms- 1.13.1
PowerShell ms- 1.5.0
debugger-for-chrome msj 3.5.0
color-highlight nau 2.3.0
vscode-docker Pet 0.0.22
vscode-versionlens pfl 0.19.1
vscode-icons rob 7.18.1
vscode-paste-and-indent Rub 0.0.8
cmake twx 0.0.17
sort-lines Tyr 1.3.0
unity-debug Uni 1.2.1
gitblame wad 2.2.0
html-css-class-completion Zig 1.14.0

Steps to Reproduce:

  1. Configure a node debug session, using useWSL: true
  2. Start debugging
  3. While it is running, open Task Manager, Details, sort by Name, scroll down to 'node'
  4. Click the "Stop Debugging" button in VS Code
  5. 'node' process doesn't get terminated

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 15, 2017
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Nov 20, 2017
@weinand weinand added this to the November 2017 milestone Nov 20, 2017
@weinand weinand modified the milestones: November 2017, December 2017 Dec 4, 2017
@thecodingdude
Copy link

I am also having this issue.

@besser
Copy link

besser commented Jan 9, 2018

I am having this issue too in either Code and Code Insiders (v1.20.0)

VSCode:
Version 1.19.1
Commit 0759f77
Date 2017-12-19T09:46:23.884Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

VSCode Insiders:
Version 1.20.0-insider
Commit b811600
Date 2018-01-08T09:42:12.918Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Node on WSL:
Version 8.9.4

@tonnyone
Copy link

I am also having this issue.

@thecodingdude
Copy link

@weinand any status updates? Sorry to bother but it's quite a breaking issue :/

@weinand weinand modified the milestones: January 2018, On Deck Jan 31, 2018
@weinand weinand modified the milestones: On Deck, February 2018 Feb 4, 2018
weinand added a commit to microsoft/vscode-node-debug that referenced this issue Feb 9, 2018
@weinand weinand closed this as completed Feb 12, 2018
@weinand weinand added the info-needed Issue requires more information from poster label Feb 12, 2018
@weinand
Copy link
Contributor

weinand commented Feb 12, 2018

fixed for "legacy" protocol (node versions < 8.0).
"inspect" protocol seems to work already.

@weinand weinand added verification-needed Verification of issue is requested and removed info-needed Issue requires more information from poster labels Feb 12, 2018
@weinand
Copy link
Contributor

weinand commented Feb 12, 2018

To verify:

  • on Windows start "bash" (to open WSL) and run "node --version". Make sure that version < 8.0. Otherwise install a 7.x version of node.
  • on Windows configure a node launch config with "useWSL": "true"
  • start debugging
  • in bash run "ps -ax" to verify that a node process is running
  • click the "Stop Debugging" button in VS Code
  • in bash run "ps -ax" to verify that no node process is running

@dbaeumer dbaeumer added the verified Verification succeeded label Mar 2, 2018
@dbaeumer
Copy link
Member

dbaeumer commented Mar 2, 2018

verified.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants