Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote - add support for searching inside files #41536

Closed
jrieken opened this issue Jan 12, 2018 · 3 comments
Closed

remote - add support for searching inside files #41536

jrieken opened this issue Jan 12, 2018 · 3 comments
Assignees
@jrieken
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality remote Remote system operations issues
Milestone
March 2018

Comments

@jrieken
Copy link
Member

jrieken commented Jan 12, 2018 •
edited
Loading

The current file system provider (proposed) api has support to find files but not to search inside files (text search). This is still a missing piece and should be added.

An working prototype has been pushed with 73ee03e
@jrieken jrieken self-assigned this Jan 12, 2018
@jrieken jrieken added feature-request Request for new features or functionality remote Remote system operations issues labels Jan 12, 2018
@jrieken jrieken added this to the January 2018 milestone Jan 12, 2018
@jrieken
Copy link
Member Author

jrieken commented Jan 12, 2018 •
edited
Loading

cc @bolinfest, @hansonw

jrieken added a commit that referenced this issue Jan 12, 2018
@jrieken
refine text search api, #41536
0b9b336
jrieken added a commit that referenced this issue Jan 16, 2018
@jrieken
add TextSearchOptions, only search in folder contributed by provider, #…
42de6cc 
…41536
@jrieken jrieken modified the milestones: January 2018, February 2018 Jan 29, 2018
@jrieken
Copy link
Member Author

jrieken commented Jan 29, 2018

First cut happened, re-purposing this to finalise the API we have today. That'll likely be

  • move search into a separate provider
  • better definition of before/after preview context
  • clarify how when in searches affects this, e.g. "exclude foo when basename.bar"

@jrieken jrieken modified the milestones: February 2018, March 2018 Feb 27, 2018
@jrieken
Copy link
Member Author

jrieken commented Mar 20, 2018

closing in favour of #45000

@jrieken jrieken closed this as completed Mar 20, 2018
@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 20, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality remote Remote system operations issues
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
1 participant
@jrieken