Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL encoding causes link to not work when ctrl + click #4315

Closed
bmdixon opened this issue Mar 16, 2016 · 5 comments
Closed

URL encoding causes link to not work when ctrl + click #4315

bmdixon opened this issue Mar 16, 2016 · 5 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2016

Comments

@bmdixon
Copy link

bmdixon commented Mar 16, 2016

  • VSCode Version: 0.10.11
  • OS Version: Windows 10 Version 1511

Steps to Reproduce:

  1. Type a URL containing symbols e.g. http://a-test-site.com/#test=true
  2. Ctrl + Click this URL
  3. URL gets encoded into http://a-test-site.com/#test%3Dtrue when opened in a browser
@alexdima
Copy link
Member

The string is good right before using URI.parse in links.ts around line 342

@alexdima alexdima assigned jrieken and unassigned alexdima Mar 17, 2016
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Mar 17, 2016
@jrieken jrieken added this to the April 2016 milestone Mar 17, 2016
@bmdixon
Copy link
Author

bmdixon commented Mar 17, 2016

Was this incorrectly associated/closed? That commit looks more like it addresses #4334 than this issue?

@alexdima
Copy link
Member

@jrieken I still see this issue on master

@alexdima alexdima reopened this Mar 17, 2016
@jrieken
Copy link
Member

jrieken commented Mar 17, 2016

yeah, sorry wrong issue.

@jrieken
Copy link
Member

jrieken commented Mar 24, 2016

related to #2990

jrieken added a commit that referenced this issue Mar 31, 2016
@jrieken
URI.toString takes parameter that controls how much encoding happens,…
1783246 
… affects #2990, #4315
@jrieken jrieken assigned isidorn and unassigned jrieken Apr 28, 2016
@isidorn isidorn added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2016
Development

No branches or pull requests
4 participants
@jrieken @isidorn @alexdima @bmdixon