Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbing after a PHP variable turns the var into <1var></var> #4588

Closed
paperworknz opened this issue Mar 22, 2016 · 5 comments
Closed

Tabbing after a PHP variable turns the var into <1var></var> #4588

paperworknz opened this issue Mar 22, 2016 · 5 comments
Assignees
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@paperworknz
Copy link

  • VSCode Version: 0.10.11
  • OS Version: Windows 8.1 Pro x64

Steps to Reproduce:

  1. Write $variable_name
  2. Press the TAB key
  3. Instead of tabbing, it turns the variable into <1variable_name></variable_name>

Super frustrating as I often tab after variable names for ease of reading (when there are a list of variables)

@aeschli aeschli assigned egamma and unassigned aeschli Mar 23, 2016
@aeschli
Copy link
Contributor

aeschli commented Mar 23, 2016

It's the emmet completion

@felixfbecker
Copy link
Contributor

But emmet should not trigger inside <?php ?> blocks, only in the HTML sections

@egamma egamma added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Mar 30, 2016
@egamma
Copy link
Member

egamma commented Mar 30, 2016

This appears to be standard emmet expansion behaviour, reproduced in other emmet integrations like sublime.

It would help to give users control to not bind emmet expand abbreviation to the TAB key.

@egamma
Copy link
Member

egamma commented Apr 17, 2016

Added a setting to disable emmet triggering on Tab "emmet.triggerExpansionOnTab": false.

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Aug 10, 2017

@paperworknz @felixfbecker

With the new Emmet improvements in VS Code 1.15, this is no longer a problem

Tab will no longer trigger Emmet, instead Emmet abbreviations will show up in suggestion/auto-completion list.

In this particular case, emmet will not provide any suggestions either

Please read more on what else is new at Emmet 2.0

@felixfbecker About triggering emmet only outside <?php >, please see #29354

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

5 participants