-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto attach is not working on Windows #46782
Comments
If you are using PowerShell then this is most likely a duplicate of #46704 |
@weinand I am unable to auto-attach with cmd or powershell. I can however attach manually with both. I will reopen. Please close if you feel these are the same root cause. |
|
Version 1.22.0-insider In the below image, I have simple server.js file launched in cmd in the integrated terminal with inspect-brk and auto attach on, but we never attach. |
still no luck after a full reboot with the changes you suggested. @RMacfarlane also tried and has the same issue as me. We both can successfully attach on Mac so we believe we have the scenario correct. |
@sbatten @RMacfarlane This works for us in ZRH. We are not able to reproduce. |
I'm leaving this open... |
Doesn't work for me on Windows either. I'll debug... |
The regex that parses the wmic output is not matching. The output for me looks like
So the problem is that the regex expects a |
I also noticed that some lines only have empty space for the CommandLine attribute, so the regex doesn't match for those either. Is that expected? |
Ha, excellent find! Thanks for you investigation. afters today's finding that it works in ZRH but not in the US I had a similar speculation (but I had forgotten that I had added the start time to get the sorting right). It would be great if you could add a '-'. Maybe there is even a ' ' if you are in the Greenwich time zone ;-) If the CommandLine is really empty, then the process is not really interesting for the functionality built into node-debug (there are no --inspect args etc.). For the process viewer it would be a problem because there we are interested in all child processes of VS Code. So, I think we can live with that bug for now. |
Fixed, and verified that it writes +000 in the UTC zone |
Testing #46570
On Windows 10, I am unable to see this feature working at all. I have a simple server.js file with a recursive setTimeout and am using Node v8.9.7. I use inspect and inspect-brk with no success. I can however use the UI to attach after launching from the integrated terminal.
The text was updated successfully, but these errors were encountered: