Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'Join editors of two groups' #50667

Closed
aeschli opened this issue May 29, 2018 · 5 comments
Closed

Improve 'Join editors of two groups' #50667

aeschli opened this issue May 29, 2018 · 5 comments
Assignees
Labels
verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented May 29, 2018

Testing #50458

  • Open the grid (2x2) layout, open some editors in it

Use 'Join editors of two groups' command

-> Need to improve the label to make this useful

@bpasero
Copy link
Member

bpasero commented May 29, 2018

@aeschli could you also describe in what way you would want to improve the label?

@bpasero bpasero added info-needed Issue requires more information from poster workbench-editor-grid Grid layout issues in the editor area labels May 29, 2018
@aeschli
Copy link
Contributor Author

aeschli commented May 30, 2018

Probably 'Join with editor group on the left', 'Join with editor group below'...

@bpasero
Copy link
Member

bpasero commented May 30, 2018

@aeschli this command is looking for neighbour groups in this order: right, down, up, left. I think I would not want to introduce new commands for each direction (and besides, we had this command before so we still need to preserve it).

We could maybe improve this command to check for the most recently used neighbour group instead of preferring the one to the right. Would that work better?

@aeschli
Copy link
Contributor Author

aeschli commented May 30, 2018

I've not used that command in the past, so I don't have any expectations on how it should behave. I just want to understand what it does before I activate it as undoing it is quite some work.
Join with next editor group would be clear to me, but should probably be the one directly right of me (or below me) and a no-op if there is no such group.

@bpasero bpasero removed the info-needed Issue requires more information from poster label May 30, 2018
@bpasero bpasero added this to the May 2018 milestone May 30, 2018
bpasero added a commit that referenced this issue May 30, 2018
@bpasero
Copy link
Member

bpasero commented May 30, 2018

I have renamed this action to Join Editor Group with Next Group and the other one we had to Join All Editor Groups and changed the code to only join to the right or bottom.

@bpasero bpasero closed this as completed May 30, 2018
@aeschli aeschli added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

2 participants