Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught TypeError: Cannot read property 'beginFrame' of undefined #51663

Closed
vscodeerrors opened this issue Jun 12, 2018 · 2 comments
Closed

Uncaught TypeError: Cannot read property 'beginFrame' of undefined #51663

vscodeerrors opened this issue Jun 12, 2018 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
June 2018

Comments

@vscodeerrors
Copy link

Issue Id: 12ca1213-b307-9bdf-d410-7c1a071af500

Versions
- 1.24.0
- 9275422
- a881696
Stack
TypeError: Cannot read property 'beginFrame' of undefined
at TextRenderLayer.onGridChanged (\node_modules.asar\vscode-xterm\lib\renderer\TextRenderLayer.js:143:24)
/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts#481:25
at \node_modules.asar\vscode-xterm\lib\renderer\Renderer.js:154:60
at Array.forEach (native)
at Renderer._renderRows (\node_modules.asar\vscode-xterm\lib\renderer\Renderer.js:154:28)
at RenderDebouncer._innerRefresh (\node_modules.asar\vscode-xterm\lib\utils\RenderDebouncer.js:29:14)
at \node_modules.asar\vscode-xterm\lib\utils\RenderDebouncer.js:24:88
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Jun 12, 2018
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jun 12, 2018
@Tyriar Tyriar added this to the June 2018 milestone Jun 12, 2018
@Tyriar Tyriar mentioned this issue Jun 12, 2018
Closed
@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2018 •
edited
Loading

Upstream PR is out: xtermjs/xterm.js#1512

@Tyriar Tyriar closed this as completed in 9481b20 Jun 20, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2018

You can review via code review of the PR

@mjbvz mjbvz added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
3 participants
@Tyriar @mjbvz @vscodeerrors