Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE in TextRenderLayer.onGridChanged #1511

Closed
Tyriar opened this issue Jun 12, 2018 · 0 comments
Closed

NPE in TextRenderLayer.onGridChanged #1511

Tyriar opened this issue Jun 12, 2018 · 0 comments
Assignees
Labels
type/bug Something is misbehaving
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2018

VS Code saw this, the xterm.js version was somewhere in between 3.4 and 3.5.

Stack 
TypeError: Cannot read property 'beginFrame' of undefined
at TextRenderLayer.onGridChanged (\node_modules.asar\vscode-xterm\lib\renderer\TextRenderLayer.js:143:24)
/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts#481:25
at \node_modules.asar\vscode-xterm\lib\renderer\Renderer.js:154:60
at Array.forEach (native)
at Renderer._renderRows (\node_modules.asar\vscode-xterm\lib\renderer\Renderer.js:154:28)
at RenderDebouncer._innerRefresh (\node_modules.asar\vscode-xterm\lib\utils\RenderDebouncer.js:29:14)
at \node_modules.asar\vscode-xterm\lib\utils\RenderDebouncer.js:24:88

VS Code issue: microsoft/vscode#51663

@Tyriar Tyriar added type/bug Something is misbehaving area/renderer labels Jun 12, 2018
@Tyriar Tyriar self-assigned this Jun 12, 2018
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jun 12, 2018
@Tyriar Tyriar added this to the 3.5.0 milestone Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

1 participant