Suggestion: append a "Read-only" label in the editor tabs for files that are read only

[miguelsolorio]

Issue Type: Bug

Testing #52573

When you have multiple workspaces (including a read-only one), it's hard to tell which files opened are the read-only ones. Wondering if it's worth appending a Read-only label so it's easier to see when you're in other tabs.

VS Code version: Code - Insiders 1.25.0-insider (923e9cc, 2018-06-26T13:00:22.932Z)
OS version: Darwin x64 17.6.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.38GB free)
Process Argv	/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_4183037
Screen Reader	no
VM	0%

Extensions (4)

Extension	Author (truncated)	Version
svgo	100	0.8.0
vscode-svgo	ajh	0.1.0
gitlens	eam	8.4.1
python	ms-	2018.6.0

(4 theme extensions excluded)

[isidorn]

I like the idea of specially decorating the tab - not sure if add read-only is the best due to limitied horizontal space.
@bpasero thoughts?

[bpasero]

@isidorn @misolori we can do it, a similar thing exists when a file is deleted on disk:

There might be a better way to indicate these things, so maybe worthwhile for a UX discussion.

[isidorn]

Yeah, I can bring it up in next weeks ux call

[isidorn]

I like being consistedf with deleted from disk, so I went with that approach.

[roblourens]

Hey @isidorn I'm seeing this show up at the wrong time

[isidorn]

Thanks @roblourens for catching that, I did a n00b mistake, pushed a fix. Is it ok now?

[vvs]

In the latest insiders build, basically all my tabs are now with (read-only). :)

[isidorn]

@vvs yeah I was very stupid. There will be a new insiders release soon, you will survive for a couple of hours :)

[vvs]

Thank you, @isidorn, I barely survived, but the latest insiders build fixed the problem! :)

But seriously, many, many thanks for all the hard work you guys are putting in the amazingVS Code, which makes my life much, much easier! :)

[isidorn]

@vvs glad to hear, you are welcome. Enjoy :)