Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if we can pull terminalProcess into the renderer process #53974

Closed
Tyriar opened this issue Jul 10, 2018 · 0 comments · Fixed by #54090
Closed

Test if we can pull terminalProcess into the renderer process #53974

Tyriar opened this issue Jul 10, 2018 · 0 comments · Fixed by #54090
Assignees
@Tyriar
Labels
debt Code quality issues terminal General terminal issues that don't fall under another label
Milestone
July 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 10, 2018 •
edited
Loading

This was separated because of an Electron issue, should check to see if it's still a problem #6469
@Tyriar Tyriar added debt Code quality issues terminal General terminal issues that don't fall under another label labels Jul 10, 2018
@Tyriar Tyriar added this to the July 2018 milestone Jul 10, 2018
@Tyriar Tyriar self-assigned this Jul 10, 2018
Tyriar added a commit that referenced this issue Jul 10, 2018
@Tyriar
Move terminalProcess to run in renderer process
35cee02 
Part of #53974
This was referenced Jul 11, 2018
Merged
Closed
Closed
@egamma egamma mentioned this issue Jul 16, 2018
Closed
49 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
July 2018
Development

Successfully merging a pull request may close this issue.

Move terminalProcess into the renderer process microsoft/vscode
1 participant
@Tyriar