Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test find in terminal improvements #59267

Closed
3 tasks done
alexr00 opened this issue Sep 24, 2018 · 4 comments
Closed
3 tasks done

Test find in terminal improvements #59267

alexr00 opened this issue Sep 24, 2018 · 4 comments
Labels
terminal General terminal issues that don't fall under another label testplan-item

Comments

@alexr00
Copy link
Member

alexr00 commented Sep 24, 2018

Ref #58826

Complexity: 2

Find widget in terminal should now find across wrapped lines(note that it still only finds the first occurrence in each line), find using regex, find whole word, and find case sensitive.

@chrmarti
Copy link
Collaborator

@alexr00 For me #59321 needs to be fixed before I can continue testing. Maybe prioritize that for today, so we can do some more testing tomorrow.

@alexr00
Copy link
Member Author

alexr00 commented Sep 25, 2018

@chrmarti, it's fixed already so you should be good for testing tomorrow already. It looks like the latest update of xterm.js had some regressions. @Tyriar reverted the update in 1e058b7

@alexr00 alexr00 closed this as completed Sep 25, 2018
@alexr00 alexr00 reopened this Sep 25, 2018
@alexr00
Copy link
Member Author

alexr00 commented Sep 25, 2018

Closed the wrong issue.

@rebornix
Copy link
Member

Tested #30874 and since we are using js regex search in main thread, it still crashes VSCode. We share the same root cause here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
terminal General terminal issues that don't fall under another label testplan-item
Projects
None yet
Development

No branches or pull requests

7 participants