Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match word doesn't align with editor find widget #59379

Closed
rebornix opened this issue Sep 25, 2018 · 2 comments
Closed

Match word doesn't align with editor find widget #59379

rebornix opened this issue Sep 25, 2018 · 2 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
October 2018

Comments

@rebornix
Copy link
Member

rebornix commented Sep 25, 2018 •
edited
Loading

#59267

In the editor, CODE with march word turned on will not match anything in CODE_OF_CONDUCT as _ is seen as a whole word but in terminal find widget, it matches CODE. IMO we don't have any word separators set for the terminal but having different behaviors of find widget options seems weird.
@vscodebot vscodebot bot added editor editor-find Editor find operations labels Sep 25, 2018
@Tyriar Tyriar added terminal General terminal issues that don't fall under another label under-discussion Issue is under discussion for relevance, priority, approach and removed editor editor-find Editor find operations labels Oct 1, 2018
@alexr00
Copy link
Member

alexr00 commented Oct 1, 2018 •
edited
Loading

These are the non-word characters right now: ~!@#$%^&*()_+-=[]{}|\;:"\',./<>? and back-tick. Looks like underscore should be removed. Are there any others that stand out?

@Tyriar
Copy link
Member

Tyriar commented Oct 5, 2018

@alexr00 just underscore seems right to me.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 5, 2018
@Tyriar Tyriar removed their assignment Oct 5, 2018
@Tyriar Tyriar added this to the October 2018 milestone Oct 5, 2018
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Oct 5, 2018
@alexr00 alexr00 mentioned this issue Oct 10, 2018
Merged
Tyriar pushed a commit to microsoft/xterm.js that referenced this issue Oct 10, 2018
@alexr00 @Tyriar
Remove underscore from non word characters list
538fc73 
This is the upstream fix for microsoft/vscode#59379
@Tyriar Tyriar closed this as completed in 7e742e1 Oct 10, 2018
@mjbvz mjbvz added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
4 participants
@rebornix @Tyriar @mjbvz @alexr00