Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endless loop in terminal #60291

Closed
jrieken opened this issue Oct 9, 2018 · 4 comments
Closed

Endless loop in terminal #60291

jrieken opened this issue Oct 9, 2018 · 4 comments
Assignees
@Tyriar
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority terminal General terminal issues that don't fall under another label
Milestone
October 2018

Comments

@jrieken
Copy link
Member

jrieken commented Oct 9, 2018

  • open vscode-nls-dev repo
  • run task > tsc --watch
  • open package.json, hover over scripts > test
  • select run test in hover
  • 🐛 vscode is toast, terminal is stuck in endless loop

screenshot 2018-10-09 at 12 59 14
@jrieken jrieken added important Issue identified as high-priority freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues labels Oct 9, 2018
@egamma egamma mentioned this issue Oct 9, 2018
Closed
@Tyriar
Copy link
Member

Tyriar commented Oct 9, 2018

/cc @jerch

@egamma
Copy link
Member

egamma commented Oct 9, 2018

@Tyriar cannot reproduce this endless loop in 1.28. In 1.28 the info message shown in the terminal is missing see #60047.

@Tyriar
Copy link
Member

Tyriar commented Oct 9, 2018

@jrieken did you have the TypedArray buffer implementation enabled?

@Tyriar Tyriar added the terminal General terminal issues that don't fall under another label label Oct 9, 2018
@Tyriar Tyriar added this to the October 2018 milestone Oct 9, 2018
@Tyriar
Copy link
Member

Tyriar commented Oct 9, 2018

It's happening on 0x200B character (zero width space), CharWidth_1.wcwidth(0x200B) returns 0

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 9, 2018
@Tyriar
Fix infinite loop
ec6a625 
See microsoft/vscode#60291
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 9, 2018
@Tyriar
Fix infinite loop
ed54676 
See microsoft/vscode#60291
@Tyriar Tyriar mentioned this issue Oct 9, 2018
Merged
@Tyriar Tyriar closed this as completed in 40371ab Oct 9, 2018
Tyriar added a commit to microsoft/xterm.js that referenced this issue Oct 9, 2018
@Tyriar
Fix infinite loop
5d0cacb 
See microsoft/vscode#60291
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
3 participants
@egamma @jrieken @Tyriar