Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API should support to create a folder #62663

Open
dbaeumer opened this issue Nov 6, 2018 · 6 comments
Open

API should support to create a folder #62663

dbaeumer opened this issue Nov 6, 2018 · 6 comments
Assignees
Labels
api feature-request Request for new features or functionality file-io File I/O workspace-edit
Milestone

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Nov 6, 2018

No description provided.

@yaohaizh
Copy link

yaohaizh commented Nov 9, 2018

Currently we are working on Java resource operation.

@dbaeumer We definitely need this for java language server implementation. Would be great if this can b implemented in short period. Thanks.

@jrieken
Copy link
Member

jrieken commented Nov 9, 2018

the workaround is to create a file inside the desired folder and then delete the file again. all within one workspace edit. that will leave you with the folder.

@yaohaizh
Copy link

yaohaizh commented Nov 9, 2018

For the workaround, on my windows' desktop, I always disabled recycle bin support. So the work around will pop up with text Failed to move 'fakeFile' to the recycle bin
This workaround is kind of issue if customer doesn't support recycle bin or have to enable options files.enableTrash: false

@ErikGrimes
Copy link

It looks like the LSP now support this. Is there still work to be done on the VS code side?

@dbaeumer
Copy link
Member Author

dbaeumer commented Nov 8, 2019

The LSP has no explict create folder right now either.

@jrieken jrieken added this to the Backlog milestone Jan 13, 2020
@EhabY
Copy link
Contributor

EhabY commented Oct 11, 2023

For the sake of completion, is it possible to support the following in the LSP WorkspaceEdit API (+ VS Code):

  • CreateFile can contain contents: string like in the VS Code implementation
  • Introduce CreateFolder to ResourceChanges with the options: { overwrite: boolean, ignoreIfExists: boolean}
  • Introduce CopyFile to ResourceChanges
    • This would be the same as RenameFile with options { overwrite: boolean, ignoreIfExists: boolean} but without deleting the source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api feature-request Request for new features or functionality file-io File I/O workspace-edit
Projects
None yet
Development

No branches or pull requests

5 participants