Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refreshing the root also triggers getChildren on folders which have been resolved yet are collapsed #67722

Closed
joaomoreno opened this issue Feb 1, 2019 · 2 comments
Closed

Refreshing the root also triggers getChildren on folders which have been resolved yet are collapsed #67722

joaomoreno opened this issue Feb 1, 2019 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Milestone
March 2019

Comments

@joaomoreno
Copy link
Member

No description provided.

@joaomoreno joaomoreno added debt Code quality issues perf tree-widget Tree widget issues labels Feb 1, 2019
@joaomoreno joaomoreno added this to the February 2019 milestone Feb 1, 2019
@joaomoreno joaomoreno self-assigned this Feb 1, 2019
@joaomoreno joaomoreno modified the milestones: February 2019, March 2019 Feb 22, 2019
@joaomoreno joaomoreno mentioned this issue Mar 5, 2019
Closed
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug and removed debt Code quality issues perf labels Mar 5, 2019
@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Mar 27, 2019
@alexr00
Copy link
Member

alexr00 commented Mar 27, 2019

I tried having a tree view in an extension with a refresh button. getChildren was only called once for the root.

@joaomoreno
Copy link
Member Author

Extension trees use the old tree, so this doesn't apply to them.

Best way to verify is to read the associated unit test. The getChildrenCalls array tracks all calls to getChildren. The test asserts that getChildren should never be called for collapsed tree nodes, even when refresh is recursive.

@joaomoreno joaomoreno removed the verification-steps-needed Steps to verify are needed for verification label Mar 27, 2019
@alexr00 alexr00 added the verified Verification succeeded label Mar 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2019
Development

No branches or pull requests
2 participants
@joaomoreno @alexr00