Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree: do not getChildren of elements that user collapsed #69526

Closed
isidorn opened this issue Feb 27, 2019 · 2 comments
Closed

Tree: do not getChildren of elements that user collapsed #69526

isidorn opened this issue Feb 27, 2019 · 2 comments
Assignees
@joaomoreno

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2019

The tree calls getChildren on elements that the user manually collapsed. This is different behavior as compared to the old tree (I verified using vscode 1.29).

Repro steps:

  1. Explorer expand some top level folder, collapse it
  2. Click refresh
  3. Notice that the Tree will ask getChildren of the collapsed folder
@isidorn isidorn added the tree-widget Tree widget issues label Feb 27, 2019
@isidorn isidorn mentioned this issue Feb 27, 2019
Closed
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Feb 27, 2019
@joaomoreno joaomoreno added this to the March 2019 milestone Feb 27, 2019
@joaomoreno
Copy link
Member

#67722

@joaomoreno joaomoreno removed bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues labels Mar 5, 2019
@joaomoreno joaomoreno removed this from the March 2019 milestone Mar 5, 2019
@isidorn
Copy link
Contributor Author

isidorn commented Mar 5, 2019

Nice!

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaomoreno @isidorn