Read only files are not properly marked in the editor

[miguelsolorio]

Issue Type: Bug

I've got a file set to Read only but am not seeing this properly marked in the editor like #53022. Did this change?

VS Code version: Code - Insiders 1.32.0-insider (003521e, 2019-02-15T06:14:19.935Z)
OS version: Darwin x64 18.0.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 3, 3
Memory (System)	16.00GB (1.69GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (5)

Extension	Author (truncated)	Version
svgo	100	0.11.0
vscode-svgo	ajh	0.1.0
gitlens	eam	9.5.1
svgpreview	kis	0.2.0
python	ms-	2019.1.0

(6 theme extensions excluded)

[isidorn]

The issue is probably that the file system provider does not mark the item as read only resulting in us not showing it as readonly in the explorer.

[gjsjohnmurray]

@isidorn - How does a file system provider mark an individual item as read only? I've been searching for this ability. I know that an extension implementing a FileSystemProvider can set isReadonly: true when it registers, thanks to #52330 (see also #51585). But what you wrote above implies it can decide on a per-file basis whether to make a file readonly or not.

[isidorn]

@gjsjohnmurray I was not correct in my comment from above. A FileSystemProvider can not mark a single item as readonly. It is a you say that it can only mark isReadonly when it registers.

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

[isidorn]

Dup of #69651