deleteFile keyboard shortcut adds the word 'Delete' to the explorer

[DanielSharp01]

Issue Type: Bug

So far when delete was pressed it deleted the file in the explorer, not it just adds the word Delete in capital letters to the file search,

VS Code version: Code - Insiders 1.36.0-insider (b7ca272, 2019-07-02T12:07:21.186Z)
OS version: Linux x64 4.18.0-25-generic snap

[isidorn]

Can you please post a video showing this?
You can F1 > toggle screen cast mode and then record so we see what keys get pressed?

I do not have a keyboard with the delete key thus I can not test this atm
Do you have some custom keybdinings?

[DanielSharp01]

I do not have any custom key bindings. I'll post a video later about the issue.

[isidorn]

Thanks

[rhangai]

It happened to me as well

Version: 1.36.0
Commit: 0f3794b
OS: Linux x64 4.15.0-54-generic

[tkvw]

Same issue here:

Version: 1.36.0
Commit: 0f3794b38477eea13fb47fbe15a42798e6129338
Date: 2019-07-03T13:20:56.241Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 4.15.0-54-generic

[sabariramc]

Same issue

Version: 1.36.0
Commit: 0f3794b38477eea13fb47fbe15a42798e6129338
Date: 2019-07-03T13:20:56.241Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 5.0.0-15-generic

[isidorn]

@joaomoreno the tree seems to be eating up the Delete key. I can not repro on win. But I can repro on Linux. This is a recent change in the past week.
It seems like something changed in the last release, since users did not hit this before.
Did we change something in how the tree handles the delete key?

Adding candidate since this is a regression.

[joaomoreno]

@jrieken Ooops.

[joaomoreno]

Yep, definitely reproducible.

Broken by 382e1a0, related to #74934

Workaround: use the context menu for now.

[jrieken]

We have logic to know whether a key press results in a printable character or not, e.g on most keyboard KEY_F prints f, SHIFT+KEY_F prints F, ESC prints nothing etc. To know if the tree should start filtering or not we run this logic and it seems broken on linux, thinking that KEY_Delete prints delete, e.g. in a text field.

[jrieken]

Talked to @alexandrudima, seems we have some utils for this:

vscode/src/vs/base/common/scanCode.ts

Line 223 in 7980cd2

export const IMMUTABLE_CODE_TO_KEY_CODE: KeyCode[] = [];

[srfrnk]

Seems like this should've been fixed in 1.36.0 am I wrong?

If so - still happens to me:

Version: 1.36.0
Commit: 0f3794b38477eea13fb47fbe15a42798e6129338
Date: 2019-07-03T13:20:56.241Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 4.15.0-54-generic

[jurosh]

@srfrnk it was reported for 1.36.0, so fix will likely be included in the next minor release. https://github.com/microsoft/vscode/milestone/99

[srfrnk]

@jurosh Thanks for the info.
I thought since commit 76608 was merged into release 1.36 - this meant it was included in 1.36.
My bad.

[mirao]

Another workaround: Disable the setting workbench.list.automaticKeyboardNavigation

[srfrnk]

Another workaround: Disable the setting workbench.list.automaticKeyboardNavigation

Thx @mirao - that helps!

[frederikheld]

You are awesome folks! I had this issue with 1.36 only on Ubuntu, not on Windows. But both hat exactly the same settings for key bindings. It drove me nuts :-P Thank you so much for fixing and deploying it so quickly!