Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Highlighting: Uppercase and Unknown Tags #79119

Closed
karlhorky opened this issue Aug 14, 2019 · 3 comments
Closed

Markdown Highlighting: Uppercase and Unknown Tags #79119

karlhorky opened this issue Aug 14, 2019 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@karlhorky
Copy link

karlhorky commented Aug 14, 2019

Note: This has been copied to microsoft/vscode-markdown-tm-grammar#49 as per #79119 (comment)

The Markdown syntax highlighting grammar doesn't recognize valid uppercase HTML tags or unknown tags (such as web components):

Screen Shot 2019-08-14 at 15 57 10

Compare that with the HTML grammar highlighting, which would be the preferable output:

Screen Shot 2019-08-14 at 16 02 35


Background: In @silvenon's MDX extension, I would like React component highlighting to work properly inline (see silvenon/vscode-mdx#9).

While this wouldn't get us all of the way there, it would at least be a step in the right direction (and would also benefit normal Markdown users).


Potentially related (HTML Textmate Grammar fix for custom HTML tags):

textmate/html.tmbundle#92
cfc2a22

@iansan5653
Copy link
Contributor

This may belong in https://github.com/microsoft/vscode-markdown-tm-grammar

@karlhorky
Copy link
Author

@iansan5653 Thanks! I've copied it to microsoft/vscode-markdown-tm-grammar#49. Will close whichever one is invalid.

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 14, 2019

Closing as upstream

@mjbvz mjbvz closed this as completed Aug 14, 2019
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 14, 2019
@mjbvz mjbvz added this to the August 2019 milestone Aug 14, 2019
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Aug 14, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants