Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files served by readonly filesystem show double '(read-only)' suffix in titlebar #79240

Closed
gjsjohnmurray opened this issue Aug 15, 2019 · 1 comment · Fixed by #79241
Closed

Files served by readonly filesystem show double '(read-only)' suffix in titlebar #79240

gjsjohnmurray opened this issue Aug 15, 2019 · 1 comment · Fixed by #79241
Assignees
@isidorn
Milestone
August 2019

Comments

@gjsjohnmurray
Copy link
Contributor

  • VSCode Version: 1.38.0-insider
  • OS Version: Windows_NT x64 10.0.17134

Originally mentioned in #69651 which covers a similar issue with tab labels.

Steps to Reproduce:

  1. Download branch at https://github.com/gjsjohnmurray/vscode-extension-samples/tree/show-69651 which contains a read-only variant of fsprovider-sample.
  2. Build and run fsprovider-sample
  3. Run these commands:
  • MemFS: Setup Workspace
  • MemFS: Create Files
  1. Go to Explorer view and open any of the files in the tree.
  2. Observe the ' (read-only) (read-only)' suffix on the filename displayed in the window titlebar.

@isidorn I am preparing a PR that will fix this issue.
@vscodebot
Copy link

vscodebot bot commented Aug 15, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@gjsjohnmurray gjsjohnmurray mentioned this issue Aug 15, 2019
Merged
@isidorn isidorn self-assigned this Aug 16, 2019
@isidorn isidorn added this to the August 2019 milestone Aug 16, 2019
isidorn added a commit that referenced this issue Aug 20, 2019
@isidorn
Merge pull request #79241 from gjsjohnmurray/fix-79240
51c4fc3 
Fix #79240 - Duplicated '(read-only)' suffix on titlebar name
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
None yet
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

Fix #79240 - Duplicated '(read-only)' suffix on titlebar name gjsjohnmurray/vscode
2 participants
@isidorn @gjsjohnmurray